Add command.repeatdly(int count) to both java and c++ #6589
+137
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight220
reviewed
May 6, 2024
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Outdated
Show resolved
Hide resolved
spacey-sooty
reviewed
May 6, 2024
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp
Outdated
Show resolved
Hide resolved
|
/format |
|
This was stated in Discord, but tests are probably failing because of an inconsistent order of when the commands in the internal deadline group are checked, which should be fixed by #6602. |
kytpbs
force-pushed
the
add-Command.Repeatdly(int-count)
branch
7 times, most recently
from
c21b4cf
to
832d5a0
Compare
|
Thanks to #6602 being merged, the tests pass correctly. I reverted back the print code and rebased them out for a cleaner history. |
spacey-sooty
approved these changes
Oct 7, 2024
Starlight220
previously approved these changes
Oct 7, 2024
KangarooKoala
approved these changes
Oct 7, 2024
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp
Outdated
Show resolved
Hide resolved
kytpbs
force-pushed
the
add-Command.Repeatdly(int-count)
branch
from
832d5a0
to
e122b0c
Compare
also, give better errors Co-Authored-By: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
I didn't know you could just pass by value by doing this thx @KangarooKoala for pointing it out. Co-Authored-By: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
|
fix formatting with rebase + force push: |
kytpbs
force-pushed
the
add-Command.Repeatdly(int-count)
branch
from
f0d8608
to
b569c8f
Compare
KangarooKoala
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the unit tests fail and there are a lot of print statements for whoever might be checking into this.
The problem is. The exact same function calls create different results between C++ and Java. I may just be the idiot but it seems to require further look into
The debug's are in different commits making it a lot easier to revert them if needed.