[epilogue] Use more specific loggers at runtime, if available #7128
Conversation
| } | ||
|
|
||
| private List<TypeMirror> getAllSubtypes() { | ||
| // This method should return all known subtypes of the given type. |
There was a problem hiding this comment.
What given type? You didn't give this function any parameters (note: you'll need to add some)
| // The implementation depends on how you track and store type hierarchies in | ||
| // your system. |
| // For simplicity, we'll return an empty list here. | ||
| return new ArrayList<>(); |
| TypeElement reflectedType, Element element, List<TypeMirror> subtypes) { | ||
| StringBuilder builder = new StringBuilder(256); | ||
|
|
||
| // Combining multiple strings into fewer append calls |
There was a problem hiding this comment.
This code runs on the programmer's computer, not the weak roboRIO. A few more append calls are negligible on performance; readability and maintainability should take higher priority
…re appends for readability
…ltiple append statements
|
@BrandonS09 Will you be able to finish this? Some changes will still be needed; in particular, |
|
Sorry, I have much less free time than when I originally opened the pull request and don't think I can finish it. Sorry for any inconveniences |
|
No worries. Just needed to know if we'd need someone else to continue this |
Changes to address #7093