[apriltag] Make AprilTagDetector.detect() use RawFrame instead of OpenCV Mat #7176
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
apriltag-make-apriltagdetector-detect-use-raw-frame-instead-of-opencv-mat
branch
2 times, most recently
from
cfce0a3
to
34f6e98
Compare
calcmogul
force-pushed
the
apriltag-make-apriltagdetector-detect-use-raw-frame-instead-of-opencv-mat
branch
from
34f6e98
to
a247f88
Compare
|
As a downstream consumer of this API, I don’t love adding 1 (2?) extra copies here. Is it possible to make RawFrame instead wrap https://docs.opencv.org/4.x/javadoc/org/opencv/core/Mat.html#dataAddr() ? |
|
Wrapping sounds like a big potential footgun; what if the OpenCV object is destroyed? I could see supporting it with some big warning signs around it, but not as the default mode of operation. |
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
added a commit
to spacey-sooty/allwpilib
that referenced
this pull request
Oct 10, 2024
Allows avoiding two copies in wpilibsuite#7176 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.