[glass] Add Alerts widget #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easiest would be to find some relevant Font Awesome icons; these are available via this header: https://github.com/wpilibsuite/allwpilib/blob/main/thirdparty/imgui_suite/generated/fonts/include/IconsFontAwesome6.h (these are injected into all the fonts, so you just string concat the macro value and output it as text). E.g. |
|
The icons were surprisingly easy with those, thank you! The widget looks like this now: |
PeterJohnson
approved these changes
Oct 16, 2024
|
|
||
| void Update() override; | ||
| bool Exists() override; | ||
| bool IsReadOnly() override { return false; } |
There was a problem hiding this comment.
I'm not familiar with Glass- Could someone explain if this is accurate? I don't see any code to respond to changes on the client side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a widget to Glass for the Alerts published with https://github.com/wpilibsuite/allwpilib/blob/main/wpilibj/src/main/java/edu/wpi/first/wpilibj/Alert.java.
Currently the types of messages are distinguished by a label and by color. I think it would be nice to add icons like this:
https://raw.githubusercontent.com/Mechanical-Advantage/NetworkAlerts/main/example.png
The icons would be nice to make it more obvious and be helpful for people with color blindness. I'm not sure what the best way to do that is, so I would appreciate help with it.