Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream_utils] Document adding a patch (NFC) #5432

Merged

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested a review from a team as a code owner July 9, 2023 18:25
Copy link
Contributor

@autoantwort autoantwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a step missing: "Add the new patch file to the list of patch files in ./update_<lib>.py"

upstream_utils/README.md Outdated Show resolved Hide resolved
upstream_utils/README.md Outdated Show resolved Hide resolved
upstream_utils/README.md Outdated Show resolved Hide resolved
upstream_utils/README.md Outdated Show resolved Hide resolved
upstream_utils/README.md Outdated Show resolved Hide resolved
upstream_utils/README.md Outdated Show resolved Hide resolved
calcmogul and others added 9 commits July 9, 2023 16:24
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
Co-authored-by: autoantwort <41973254+autoantwort@users.noreply.github.com>
@calcmogul calcmogul changed the title [upstream_utils] Document adding a patch [upstream_utils] Document adding a patch (NFC) Aug 24, 2023
@PeterJohnson PeterJohnson merged commit 349141b into wpilibsuite:main Aug 24, 2023
23 checks passed
@calcmogul calcmogul deleted the upstream-utils-document-adding-a-patch branch August 24, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants