[cmd] Add interruptor parameter to onCommandInterrupt callbacks #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangarooKoala
changed the title
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java
Outdated
Show resolved
Hide resolved
KangarooKoala
force-pushed
the
cmd-callbacks
branch
from
4414b95
to
3eecf0f
Compare
Starlight220
approved these changes
Sep 14, 2023
Cache Optional.empty() Use separate lists for toCancel queue
KangarooKoala
force-pushed
the
cmd-callbacks
branch
from
3eecf0f
to
20c2366
Compare
rzblue
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5301
Notes:
Optional.empty()instance since each call could potentially allocate a new instance. (There is no guarantee it is a singleton) This is not a problem for C++, which simply uses thestd::nulloptconstant.std::pairwhich does not allocate a new object (to my understanding).