Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upstream_utils] Upgrade to LLVM 17.0.1 #5482

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[upstream_utils] Upgrade to LLVM 17.0.1 #5482

merged 2 commits into from
Sep 22, 2023

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul force-pushed the upgrade-llvm branch 5 times, most recently from 23cd0be to 6799383 Compare July 31, 2023 00:23
@calcmogul
Copy link
Member Author

calcmogul commented Aug 1, 2023 •
edited
Loading

The following tests are failing.

[  FAILED  ] 9 tests, listed below:
[  FAILED  ] JsonElementObjectRemoveTest.Begin
[  FAILED  ] JsonElementObjectRemoveTest.BeginConst
[  FAILED  ] JsonIteratorObjectTest.BeginEnd
[  FAILED  ] JsonIteratorObjectTest.ConstBeginEnd
[  FAILED  ] JsonIteratorObjectTest.CBeginEnd
[  FAILED  ] JsonIteratorObjectTest.ConstCBeginEnd
[  FAILED  ] JsonIteratorObjectTest.KeyValue
[  FAILED  ] CborRfc7049AppendixAObjectTests/CborRoundtripTest.Case/1, where GetParam() = 40-byte object <DA-4B 6B-C1 FA-55 00-00 50-D2 B9-C1 FA-55 00-00 59-D2 B9-C1 FA-55 00-00 59-D2 B9-C1 FA-55 00-00 01-73 74-73 00-00 00-00>
[  FAILED  ] CborRfc7049AppendixAObjectTests/CborRoundtripTest.Case/3, where GetParam() = 40-byte object <08-4C 6B-C1 FA-55 00-00 50-D2 B9-C1 FA-55 00-00 65-D2 B9-C1 FA-55 00-00 65-D2 B9-C1 FA-55 00-00 01-73 74-73 00-00 00-00>

These failures may be due to behavior changes in the LLVM containers breaking the expected output for JSON serialization or changing iterator behavior.

Using the upstream version of our JSON library instead may avoid the failures since it doesn't use LLVM containers.

@calcmogul calcmogul changed the title Upgrade to LLVM 17.0.0 [upstream_utils] Upgrade to LLVM 17.0.0 Aug 3, 2023
@calcmogul calcmogul force-pushed the upgrade-llvm branch 2 times, most recently from 1de903c to b263ebb Compare August 18, 2023 18:03
@calcmogul calcmogul force-pushed the upgrade-llvm branch 4 times, most recently from cedfd3a to 688f282 Compare August 26, 2023 22:30
@calcmogul calcmogul force-pushed the upgrade-llvm branch 3 times, most recently from 26c6c96 to 873cc09 Compare September 8, 2023 05:53
@calcmogul calcmogul force-pushed the upgrade-llvm branch 4 times, most recently from 25d256e to 6296905 Compare September 16, 2023 03:07
@calcmogul calcmogul changed the title [upstream_utils] Upgrade to LLVM 17.0.0 [upstream_utils] Upgrade to LLVM 17.0.1 Sep 20, 2023
@calcmogul calcmogul marked this pull request as ready for review September 20, 2023 05:06
@calcmogul calcmogul requested review from PeterJohnson and a team as code owners September 20, 2023 05:06
@calcmogul calcmogul requested a review from a team as a code owner September 20, 2023 05:37
@PeterJohnson PeterJohnson merged commit 1b6ec5a into wpilibsuite:main Sep 22, 2023
24 checks passed
@calcmogul calcmogul deleted the upgrade-llvm branch September 22, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calcmogul @PeterJohnson