-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IdleCommand to wpilibJ2 command framework #5555
Commits on Aug 19, 2023
-
Add IdleCommand to wpilibJ2 command framework
Implemented an IdleCommand class and a builder for this class in the Commands class. These changes provide a way to construct commands that do nothing until they're interrupted. This could be useful when creating continuously scheduled commands that are intended to run only once, such as subsystem default commands.
Configuration menu - View commit details
-
Copy full SHA for 4e02d6c - Browse repository at this point
Copy the full SHA 4e02d6cView commit details -
Relocated the implementation of the IdleCommand as a factory method i…
…n the Commands class instead of having it as an isolated class. Moved the idle factory method alongside the other idling / waiting factories
Configuration menu - View commit details
-
Copy full SHA for f5291a3 - Browse repository at this point
Copy the full SHA f5291a3View commit details
Commits on Aug 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 93bb0ef - Browse repository at this point
Copy the full SHA 93bb0efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2094ab1 - Browse repository at this point
Copy the full SHA 2094ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5807d4 - Browse repository at this point
Copy the full SHA b5807d4View commit details -
Refactor idle command call in Commands.java & Commands.cpp
Changed the way `idle` command is created from using a new instance of `RunCommand` to a call to `run`, improving code readability and consistency.
Configuration menu - View commit details
-
Copy full SHA for 7e38ba4 - Browse repository at this point
Copy the full SHA 7e38ba4View commit details -
Remove requirement parameter from
idle
commandRefactored the way `idle` command is created in Commands.java and Commands.cpp by removing the requirement parameter.
Configuration menu - View commit details
-
Copy full SHA for e435bdd - Browse repository at this point
Copy the full SHA e435bddView commit details -
Improve formatting and readability in Commands files
Applied minor changes to improve the readability and maintenance of the code in `Commands.java`, `Commands.cpp` and `Commands.h`. Aligned the lambda expression and adjusted the indentation of comments for the `idle` method. No functionality change was introduced.
Configuration menu - View commit details
-
Copy full SHA for 8983fd2 - Browse repository at this point
Copy the full SHA 8983fd2View commit details -
Remove redundant parameter description in Commands.h
Redundant '@param requirements' in the function documentation of the 'idle' method is removed in `Commands.h` file.
Configuration menu - View commit details
-
Copy full SHA for b18b13b - Browse repository at this point
Copy the full SHA b18b13bView commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1aee8af - Browse repository at this point
Copy the full SHA 1aee8afView commit details