Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IdleCommand to wpilibJ2 command framework #5555

Merged
merged 10 commits into from
Aug 29, 2023

Commits on Aug 19, 2023

  1. Add IdleCommand to wpilibJ2 command framework

    Implemented an IdleCommand class and a builder for this class in the Commands class. These changes provide a way to construct commands that do nothing until they're interrupted. This could be useful when creating continuously scheduled commands that are intended to run only once, such as subsystem default commands.
    TapChap committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    4e02d6c View commit details
    Browse the repository at this point in the history
  2. Relocated the implementation of the IdleCommand as a factory method i…

    …n the Commands class instead of having it as an isolated class.
    
    Moved the idle factory method alongside the other idling / waiting factories
    TapChap committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f5291a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Configuration menu
    Copy the full SHA
    93bb0ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2094ab1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5807d4 View commit details
    Browse the repository at this point in the history
  4. Refactor idle command call in Commands.java & Commands.cpp

    Changed the way `idle` command is created from using a new instance of `RunCommand` to a call to `run`, improving code readability and consistency.
    TapChap committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    7e38ba4 View commit details
    Browse the repository at this point in the history
  5. Remove requirement parameter from idle command

    Refactored the way `idle` command is created in Commands.java and Commands.cpp by removing the requirement parameter.
    TapChap committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    e435bdd View commit details
    Browse the repository at this point in the history
  6. Improve formatting and readability in Commands files

    Applied minor changes to improve the readability and maintenance of the code in `Commands.java`, `Commands.cpp` and `Commands.h`. Aligned the lambda expression and adjusted the indentation of comments for the `idle` method. No functionality change was introduced.
    TapChap committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    8983fd2 View commit details
    Browse the repository at this point in the history
  7. Remove redundant parameter description in Commands.h

    Redundant '@param requirements' in the function documentation of the 'idle' method is removed in `Commands.h` file.
    TapChap committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    b18b13b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    1aee8af View commit details
    Browse the repository at this point in the history