-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp cmd] Fix leakage and multiple composition bug in SelectCommand #5571
Conversation
556ae5c
to
21332b4
Compare
61eee02
to
7fbc4d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That command should probably be marked as composed, for good measure.
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java
Outdated
Show resolved
Hide resolved
Merging with #5569 to avoid conflicts |
(Continuing my review from the other PR)
That's not a bad idea, and can be done easily by adding to the As long as there aren't active changes to tests specific to other classes, I'd consider it in scope. |
#5581 adds tests for this in java. I'm not sure how to test the behavior in c++, since ownership semantics largely prevent users from doubly composing commands. I'd rather stick the tests in that PR, since it's already touching a bunch of files. |
No description provided.