[wpimath] Add angular jerk unit #5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The volume header uses |
|
/format |
|
You can add unit tests for the new type to wpimath/src/test/native/cpp/UnitsTest.cpp. |
|
Including the angular_jerk.h header at the top of UnitsTest.cpp should fix some errors. |
calcmogul
requested changes
Aug 29, 2023
calcmogul
requested changes
Aug 29, 2023
|
Otherwise, looks good to me. |
calcmogul
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We [CTRE] would benefit from a Angular Jerk unit.
I haven't tested it yet.
I'm not sure I like using
_cbfor "cubed", maybe someone else can think of a better suffix.