-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpilib] Add functional interface equivalents to MotorController #6053
Merged
PeterJohnson
merged 13 commits into
wpilibsuite:main
from
calcmogul:wpilib-replace-motor-controller-interface-with-functional-interface
Jan 1, 2024
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5ecbf82
[wpilib] Replace MotorController interface with functional interface
calcmogul 8644dde
Remove redundant motor inversion from C++ example
calcmogul 0cef781
Add Sendable getters
calcmogul a8f38d0
Merge branch 'main' into wpilib-replace-motor-controller-interface-wi…
calcmogul a452b42
Update internal variables in StopMotor()
calcmogul 7456207
Add rvalue support to PWMMotorController::AddFollower()
calcmogul e0f6608
Merge branch 'main' into wpilib-replace-motor-controller-interface-wi…
calcmogul c491a67
Move AddChild() calls to deprecated drive constructor
calcmogul faaa0a0
Add SendableRegistry AddChild() calls to examples
calcmogul ff4c567
Deprecate MecanumDrive constructor
calcmogul 26e05e8
Undeprecate MotorController drive constructors for now
calcmogul 3b3d2c3
Merge branch 'main' into wpilib-replace-motor-controller-interface-wi…
calcmogul 28dfe3e
Undeprecate MotorController
calcmogul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be when we eventually deprecate it again, and finding where those go was a lot of work because they're scattered all over the motor controller codebase.