[wpiutil,cscore,apriltag] Fix RawFrame #6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
force-pushed
the
fix-rawframe
branch
2 times, most recently
from
bc16bcb
to
dbf780f
Compare
mcm001
reviewed
Dec 26, 2023
PeterJohnson
force-pushed
the
fix-rawframe
branch
from
dbf780f
to
803b94f
Compare
|
Other comment, do we have any unit tests to compare pixels against a known good tag image? Might be good to catch similar shenanigans to the instigating issue, but obviously not required |
PeterJohnson
force-pushed
the
fix-rawframe
branch
from
803b94f
to
ab481a3
Compare
ncorrea210
suggested changes
Dec 26, 2023
apriltag/src/main/java/edu/wpi/first/apriltag/jni/AprilTagJNI.java
Outdated
Show resolved
Hide resolved
PeterJohnson
force-pushed
the
fix-rawframe
branch
from
ab481a3
to
50f2fd7
Compare
|
Test added. |
mcm001
approved these changes
Dec 27, 2023
apriltag/src/test/java/edu/wpi/first/apriltag/AprilTagGenerationTest.java
Outdated
Show resolved
Hide resolved
ncorrea210
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawFrame was broken in multiple ways, e.g. use-after-free in AprilTag. Fix up API and use cases.