Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Mark ParallelDeadlineGroup.setDeadline() final #6102

Merged
merged 2 commits into from
Dec 27, 2023
Merged

[cmd] Mark ParallelDeadlineGroup.setDeadline() final #6102

merged 2 commits into from
Dec 27, 2023

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested a review from a team as a code owner December 27, 2023 04:55
Starlight220
Starlight220 requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer making those methods final instead.

@calcmogul
Copy link
Member Author

Which ones?

@Starlight220
Copy link
Member

setDeadline (addCommands is already final)

@calcmogul calcmogul changed the title Suppress this-escape warning [cmd] Fix this-escape warning Dec 27, 2023
@Starlight220 Starlight220 changed the title [cmd] Fix this-escape warning [cmd] Mark ParallelDeadlineGroup.setDeadline() final Dec 27, 2023
@Starlight220
Copy link
Member

Is there a need to modify C++ to match? I think it isn't virtual so no need?

@calcmogul
Copy link
Member Author

Yea, I already checked. C++ won't even let you mark a method as final that isn't virtual.

@PeterJohnson PeterJohnson merged commit e07de37 into wpilibsuite:main Dec 27, 2023
27 checks passed
@calcmogul calcmogul deleted the suppress-this-escape-warning branch December 27, 2023 18:30
r4stered pushed a commit to r4stered/allwpilib that referenced this pull request Dec 28, 2023
@calcmogul @r4stered
[commands] Mark ParallelDeadlineGroup.setDeadline() final (wpilibsuit…
f26e5df 
…e#6102)

Suppress this-escape warning.
Oblarg pushed a commit to Oblarg/allwpilib that referenced this pull request Dec 30, 2023
@calcmogul
[commands] Mark ParallelDeadlineGroup.setDeadline() final (wpilibsuit…
900adc5 
…e#6102)

Suppress this-escape warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

@Starlight220 Starlight220 Starlight220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calcmogul @Starlight220 @PeterJohnson