Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to detect if the CAN Stream has overflowed #6105

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Add method to detect if the CAN Stream has overflowed #6105

merged 6 commits into from
Dec 29, 2023

Conversation

ThadHouse
Copy link
Member

Currently a stream overflow will just throw an exception. We want the exception to contain the data that was read, as there is still valid data. Its just that some data was lost.

@ThadHouse ThadHouse requested a review from a team as a code owner December 27, 2023 20:04
@ThadHouse
Copy link
Member Author

/format

@PeterJohnson
Copy link
Member

/format

@PeterJohnson
Copy link
Member 

JNITest > jniLinkTest() FAILED
    java.lang.NoSuchMethodError: Ledu/wpi/first/hal/can/CANStreamOverflowException;.<init>(Ljava/lang/String;)V
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)

@PeterJohnson PeterJohnson merged commit 24a76be into wpilibsuite:main Dec 29, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThadHouse @PeterJohnson @KangarooKoala