[hal] Add CanApitypes to java (Feature Parity) #6121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m10653
commented
Dec 31, 2023
Comment on lines
+25
to
+26
| public static final int kTeamManufacturer = CANAPITypes.CANManufacturer.kTeamUse.id; | ||
| public static final int kTeamDeviceType = CANAPITypes.CANDeviceType.kMiscellaneous.id; |
There was a problem hiding this comment.
kTeamManufacturer and kTeamDeviceType seem a bit redundant now but I did not want to remove or change them as that would/could break api compatibility.
PeterJohnson
reviewed
Jan 1, 2024
m10653
changed the title
PeterJohnson
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the CanApitypes to Java, and updates a few magic values to use the enum.