[docs] Add missing JavaDocs #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
docs-add-missing-javadocs
branch
2 times, most recently
from
a541d41
to
c28205d
Compare
|
How many JavaDoc warnings are there now? |
|
2411 warnings. At this rate, we may need a small army of volunteers if we want it done within a month. |
|
Seems like maybe some of the functional changes should be a different PR that's easier to review (ie protected -> private members) |
|
C++ already had them as private members. |
|
You sure it's 2411 warnings? When I build docs for main, I get 2423 warnings. I refuse to believe you only removed 12 warnings, it should be way more. |
|
I got 2216 warnings. That's 207 warnings removed for #5808. |
|
I'm using JDK 21. I got 2756 warnings on main. |
calcmogul
force-pushed
the
docs-add-missing-javadocs
branch
from
c28205d
to
0e609ba
Compare
calcmogul
force-pushed
the
docs-add-missing-javadocs
branch
from
0e609ba
to
8563cd3
Compare
PeterJohnson
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.