[wpimath] Add PoseEstimator.sampleAt() #6426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
reviewed
Apr 27, 2024
wpimath/src/test/native/cpp/estimator/DifferentialDrivePoseEstimatorTest.cpp
Outdated
Show resolved
Hide resolved
|
Other than that, looks good to me. |
calcmogul
changed the title
calcmogul
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6366.
I named it
sampleAt()instead ofgetEstimatedPosition()since that's what's in #5473, but I could rename it to match the method name in the issue title.The tests are right now all in one test to make sure the whole history makes sense, but I could also see a point for splitting apart the tests.