Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command.repeatdly(int count) to both java and c++ #6589

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add command.repeatdly(int count) to both java and c++ #6589

wants to merge 4 commits into from
+137 −0

Commits on Oct 10, 2024

  1. add Command.repeatedly(int times) to both java and c++ 

    Also has unit tests in it!
    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5b2c924 View commit details
    Browse the repository at this point in the history

  2. use Atomic Integer instead of array for refrence-passing.

    @kytpbs
    kytpbs committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e122b0c View commit details
    Browse the repository at this point in the history

  3. improve tests so they don't hang when failing 

    also, give better errors

Co-Authored-By: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
    @kytpbs @KangarooKoala
    kytpbs and KangarooKoala committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b50a395 View commit details
    Browse the repository at this point in the history

  4. use pass by value similar to convention 

    I didn't know you could just pass by value by doing this thx @KangarooKoala  for pointing it out.

Co-Authored-By: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com>
    @kytpbs @KangarooKoala
    kytpbs and KangarooKoala committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b569c8f View commit details
    Browse the repository at this point in the history