Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataLogManager usage reporting #6640

Closed
wants to merge 2 commits into from

Conversation

WispySparks
Copy link
Contributor

@WispySparks WispySparks commented May 20, 2024

Resolves #6606

@WispySparks WispySparks requested review from a team as code owners May 20, 2024 21:00
@WispySparks
Copy link
Contributor Author

/format

@calcmogul
Copy link
Member

calcmogul commented May 20, 2024

Unfortunately, we can't just add a usage reporting ID like this. It has to go through our NI contact since they manage the list instead of us. The list gets updated once per year right before beta. (I know, not the lowest overhead process...)

@WispySparks
Copy link
Contributor Author

WispySparks commented May 20, 2024

Oh bummer I didn't know that, what should I do with this PR?

@calcmogul
Copy link
Member

It can be closed. I've added the attn: NI label to the original issue so we hopefully don't forget to add some usage reporting IDs like we have in prior years.

@WispySparks WispySparks deleted the usage-report-dlm branch May 25, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add usage reporting ID for DataLogManager (and/or DataLog)
2 participants