Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Deprecate Command.schedule() #7072

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[cmd] Deprecate Command.schedule() #7072

wants to merge 4 commits into from
+77 −66

Commits on Oct 18, 2024

  1. [cmd] Deprecate Command.schedule() 

    It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.
    @Gold856
    Gold856 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    55e19f5 View commit details
    Browse the repository at this point in the history

  2. Replace most usages of schedule()

    @Gold856
    Gold856 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c8b610e View commit details
    Browse the repository at this point in the history

  3. Update wpilibNewCommands/src/test/native/cpp/frc2/command/CommandSend… 

    …ableButtonTest.cpp

Co-authored-by: Starlight220 <53231611+Starlight220@users.noreply.github.com>
    @Gold856 @Starlight220
    Gold856 and Starlight220 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d0fa749 View commit details
    Browse the repository at this point in the history

  4. More fixes

    @Gold856
    Gold856 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3f6f458 View commit details
    Browse the repository at this point in the history