[commands] Clarified error messages for parallel composition commands #7161
+113
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
|
|
/format |
|
You'll need to install and run wpiformat yourself, the PR format command will not work if the PR is based on your main branch. For the future, it's best to make a branch for each PR. |
…between commands in a parallel group
Starlight220
reviewed
Oct 5, 2024
| var currentRequirements = getRequirements(); | ||
| if (!Collections.disjoint(command.getRequirements(), currentRequirements)) { | ||
| String requirementsStr = command.getRequirements() | ||
| .stream() |
There was a problem hiding this comment.
The Stream API is really inefficient (for these use cases) and is generally avoided in the WPILib codebase
There was a problem hiding this comment.
I feel like it’s probably fine to use the stream api here, even if it’s slow, because this code will only run when an error happens anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #6353.