Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

CANivore error when loading old config #482

Closed
agasser opened this issue Feb 6, 2023 · 5 comments
Closed

CANivore error when loading old config #482

agasser opened this issue Feb 6, 2023 · 5 comments
Labels
component: generation Generation of robot projects

Comments

@agasser
Copy link

agasser commented Feb 6, 2023

Configs created before v2023.3.2 give an error when loading.
image

Steps to reproduce

  1. Create a config in a previous 2023 version of SysId
  2. Upgrade SysId
  3. Attempt to load the config
@calcmogul
Copy link
Member

CANivore support caused breaking changes in the project generator JSON.

@calcmogul calcmogul transferred this issue from wpilibsuite/allwpilib Feb 6, 2023
@calcmogul calcmogul changed the title [SysId] CANIvore error loading old config CANIvore error loading old config Feb 6, 2023
@calcmogul calcmogul changed the title CANIvore error loading old config CANivore error when loading old config Feb 6, 2023
@agasser
Copy link
Author

agasser commented Feb 6, 2023

CANivore support caused breaking changes in the project generator JSON.

It looks that way. It probably should default to "rio".

@calcmogul
Copy link
Member

Could you upload an old JSON for testing?

@agasser
Copy link
Author

agasser commented Feb 6, 2023

shooter-config.json.txt

@agasser agasser mentioned this issue Feb 22, 2023
Closed
@calcmogul calcmogul added the component: generation Generation of robot projects label Sep 20, 2023
@calcmogul
Copy link
Member

OBE by #518.

@calcmogul calcmogul closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: generation Generation of robot projects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agasser @calcmogul