refactor(global): ♻️ fix a small bug

as we decide we have to pass data in constructor in a pattern so I change that Red #54
wrappid · Jan 6, 2025 · 4621282 · 4621282
1 parent 77d98cd
commit 4621282
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/components/data/viewer/Viewer.data.ts b/app/components/data/viewer/Viewer.data.ts
@@ -13,8 +13,8 @@ export abstract class ViewerData {
   protected viewerRenderedComponent: string;
 
   constructor(
-    viewerType: typeof ViewerFactory.VARIANTS[keyof typeof ViewerFactory.VARIANTS],
-    entityData: DynamicEntity
+    entityData: DynamicEntity,
+    viewerType: typeof ViewerFactory.VARIANTS[keyof typeof ViewerFactory.VARIANTS]
   ) {
     this.viewerId = getWrappidUUID();
     this.viewerType = viewerType;

diff --git a/app/components/data/viewer/json/JsonViewer.data.ts b/app/components/data/viewer/json/JsonViewer.data.ts
@@ -9,8 +9,8 @@ export class JsonViewerData extends ViewerData{
     entityData: DynamicEntity
   ){
     super(
-      ViewerFactory.VARIANTS.JSON,
-      entityData
+      entityData,
+      ViewerFactory.VARIANTS.JSON
     );
     this.setViewerRenderedComponent(JSON_VIEWER);
   }

diff --git a/app/components/data/viewer/model/ModelViewer.data.ts b/app/components/data/viewer/model/ModelViewer.data.ts
@@ -11,8 +11,8 @@ export class ModelViewerData extends ViewerData{
     entityData: DynamicEntity
   ){
     super(
-      ViewerFactory.VARIANTS.MODEL,
-      entityData
+      entityData,
+      ViewerFactory.VARIANTS.MODEL
     );
     this.setViewerRenderedComponent(MODEL_VIEWER);
   }