From 4621282f4fbbf32d25430298d5be2baffa162a65 Mon Sep 17 00:00:00 2001 From: Pritam Bag <130136389+PritamBag@users.noreply.github.com> Date: Mon, 6 Jan 2025 15:29:49 +0530 Subject: [PATCH] refactor(global): :recycle: fix a small bug as we decide we have to pass data in constructor in a pattern so I change that Red #54 --- app/components/data/viewer/Viewer.data.ts | 4 ++-- app/components/data/viewer/json/JsonViewer.data.ts | 4 ++-- app/components/data/viewer/model/ModelViewer.data.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/components/data/viewer/Viewer.data.ts b/app/components/data/viewer/Viewer.data.ts index 38f4e45..b4e445b 100644 --- a/app/components/data/viewer/Viewer.data.ts +++ b/app/components/data/viewer/Viewer.data.ts @@ -13,8 +13,8 @@ export abstract class ViewerData { protected viewerRenderedComponent: string; constructor( - viewerType: typeof ViewerFactory.VARIANTS[keyof typeof ViewerFactory.VARIANTS], - entityData: DynamicEntity + entityData: DynamicEntity, + viewerType: typeof ViewerFactory.VARIANTS[keyof typeof ViewerFactory.VARIANTS] ) { this.viewerId = getWrappidUUID(); this.viewerType = viewerType; diff --git a/app/components/data/viewer/json/JsonViewer.data.ts b/app/components/data/viewer/json/JsonViewer.data.ts index 22100a6..9b84244 100644 --- a/app/components/data/viewer/json/JsonViewer.data.ts +++ b/app/components/data/viewer/json/JsonViewer.data.ts @@ -9,8 +9,8 @@ export class JsonViewerData extends ViewerData{ entityData: DynamicEntity ){ super( - ViewerFactory.VARIANTS.JSON, - entityData + entityData, + ViewerFactory.VARIANTS.JSON ); this.setViewerRenderedComponent(JSON_VIEWER); } diff --git a/app/components/data/viewer/model/ModelViewer.data.ts b/app/components/data/viewer/model/ModelViewer.data.ts index 352c6a1..b6ecb02 100644 --- a/app/components/data/viewer/model/ModelViewer.data.ts +++ b/app/components/data/viewer/model/ModelViewer.data.ts @@ -11,8 +11,8 @@ export class ModelViewerData extends ViewerData{ entityData: DynamicEntity ){ super( - ViewerFactory.VARIANTS.MODEL, - entityData + entityData, + ViewerFactory.VARIANTS.MODEL ); this.setViewerRenderedComponent(MODEL_VIEWER); }