Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: npm install on the root working #127

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

techoneel
Copy link
Member

@techoneel techoneel commented Jul 12, 2024

Description

npm install on the project's root directory from terminal not working

Related Issues

Ref #126

Testing

Tested locally after the changes and it's working fine.

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Not applicable.

Reviewers

@samhere17 @anantakumarghosh

Thank you for your contribution!-->


Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

added react-dom@18.2.0 package to the root package.json to resolve the installation error

Ref #126
@techoneel techoneel self-assigned this Jul 12, 2024
@techoneel techoneel added the bugfix Pull Requests that fixes a bug label Jul 12, 2024
@techoneel
Copy link
Member Author

Since this is an urgent requirement and android build issue dependent on this particular problem.
I'm merging this pull request for resolve dependency.

@techoneel techoneel closed this Jul 12, 2024
@techoneel techoneel reopened this Jul 12, 2024
@techoneel techoneel merged commit bf93123 into development Jul 12, 2024
11 checks passed
Copy link
Member

@anantakumarghosh anantakumarghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping wrappid improve @techoneel

@techoneel techoneel changed the title fix(config): 🐛 npm install on the root not working bugfix: npm install on the root working Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull Requests that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants