-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(enh) add OS / Process.exit #74
Draft
joshgoebel
wants to merge
4
commits into
wren-lang:main
Choose a base branch
from
joshgoebel:process_exit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
process_exit
branch
2 times, most recently
from
May 10, 2021 05:05
6e3168d
to
830129d
Compare
Updated: Attempts to properly clean up fully before stopping completely. This also improves scheduler error handling which also uses |
Converting to draft, seems obvious now this needs more work. |
Fairly confident this works: The flow:
I can update my patch here if there is agreement this is a viable solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is needed for usage with terminal scripting, CI (test suites), build systems, etc. Being able to return an error code (without purposely crashing) is necessary for many different uses cases.
I think this is sufficient because freeVm() does all the
cleanup calling ioShutdown and schedulerShutdown(). What
I'm not 100% sure of is if I need to address this:
If so I think I can add it fairly easily.I've fully implemented closing all handles now.Ref: libuv/libuv#709