Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Username Recovery multichannel support configs #865

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Oct 18, 2024

Proposed changes in this pull request

[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]

  • Add separate configs for the email and sms channel in username recovery.

Related issues

Important notes

  • We are not removing the previous username enable config which is used to disable the connector when both email and sms channels are disabled.
  • To keep the backward compatibility we are using default value of the email channel as username enable value.

Related PRs

@PasinduYeshan
Copy link
Contributor

Update unit tests for this class.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 30 lines in your changes missing coverage. Please review.

Project coverage is 37.92%. Comparing base (a1eca1e) to head (cf58038).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
...ice/impl/username/UsernameRecoveryManagerImpl.java 72.30% 15 Missing and 3 partials ⚠️
...ernal/service/impl/UserAccountRecoveryManager.java 84.44% 2 Missing and 5 partials ⚠️
...tity/governance/IdentityGovernanceServiceImpl.java 87.17% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #865      +/-   ##
============================================
+ Coverage     36.53%   37.92%   +1.39%     
- Complexity     1475     1559      +84     
============================================
  Files           267      267              
  Lines         15815    15965     +150     
  Branches       2183     2214      +31     
============================================
+ Hits           5778     6055     +277     
+ Misses         9321     9206     -115     
+ Partials        716      704      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sadilchamishka
sadilchamishka previously approved these changes Oct 22, 2024
sadilchamishka
sadilchamishka previously approved these changes Oct 28, 2024
@nilasini
Copy link
Contributor

nilasini commented Nov 1, 2024

As I noticed for SMS based password recovery we have handled the configuration in a different way[1]. Isn't it inconsistence?

[1] wso2/product-is#21357

@Malith-19
Copy link
Contributor Author

Update the logic of handling the username recovery configs.

Followed the same ondemand migration from a7a13d5

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11737470486

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11737470486
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11737470486

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11838385429

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11838385429
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11838385429

@ashensw ashensw merged commit a1146e2 into wso2-extensions:master Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants