-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Username Recovery multichannel support configs #865
Add Username Recovery multichannel support configs #865
Conversation
...tity.recovery/src/main/java/org/wso2/carbon/identity/recovery/IdentityRecoveryConstants.java
Show resolved
Hide resolved
Update unit tests for this class. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
============================================
+ Coverage 36.53% 37.92% +1.39%
- Complexity 1475 1559 +84
============================================
Files 267 267
Lines 15815 15965 +150
Branches 2183 2214 +31
============================================
+ Hits 5778 6055 +277
+ Misses 9321 9206 -115
+ Partials 716 704 -12 ☔ View full report in Codecov by Sentry. |
...tity.recovery/src/main/java/org/wso2/carbon/identity/recovery/IdentityRecoveryConstants.java
Show resolved
Hide resolved
As I noticed for SMS based password recovery we have handled the configuration in a different way[1]. Isn't it inconsistence? |
Followed the same ondemand migration from a7a13d5 |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11737470486
...nce/src/test/java/org/wso2/carbon/identity/governance/IdentityGovernanceServiceImplTest.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11838385429
Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
Related issues
Important notes
Related PRs