Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OAuth2 application management through DCR in sub organizations #2578

Merged

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Sep 30, 2024

Proposed changes in this pull request

  • $subject
  • Improvement for : Support for creating OAuth 2.0 clients inside B2B organizations for B2B API access wso2/product-is#21208
  • OAuth2 application management will be allowed through the DCR endpoint.
    /t/{tenant-domain}/o/{org-id}/api/identity/oauth2/dcr/v1.1/register
  • This change contains the following improvements in the sub organization level
    • OAuth2 application creation
    • OAuth2 application get by client id
    • OAuth2 application get by client / application name
    • OAuth2 application update by client id
    • OAuth2 application delete by client id
  • Contains some supportive method improvements to the aforementioned main operations.

When should this PR be merged

@ShanChathusanda93 ShanChathusanda93 force-pushed the dcr-impr-branch branch 3 times, most recently from 92e8d33 to 725f30e Compare November 1, 2024 13:16
pom.xml Outdated Show resolved Hide resolved
@ShanChathusanda93 ShanChathusanda93 changed the title Improve DCR process in OAuth Allow OAuth2 application creation from DCR in sub organizations Nov 1, 2024
@ShanChathusanda93 ShanChathusanda93 changed the title Allow OAuth2 application creation from DCR in sub organizations Allow OAuth2 application management through DCR in sub organizations Nov 1, 2024
@ShanChathusanda93 ShanChathusanda93 marked this pull request as ready for review November 1, 2024 13:27
@ShanChathusanda93 ShanChathusanda93 force-pushed the dcr-impr-branch branch 2 times, most recently from f7ec0ad to dd68cd0 Compare November 27, 2024 08:19
@ShanChathusanda93 ShanChathusanda93 force-pushed the dcr-impr-branch branch 2 times, most recently from ea2d920 to 8ddbb51 Compare November 28, 2024 05:57
@Thumimku
Copy link
Contributor

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

@ShanChathusanda93
Copy link
Contributor Author

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

@Thumimku

This PR is in WIP and will be completed in next couple of days. Hence keeping this open as for now.

@ShanChathusanda93 ShanChathusanda93 force-pushed the dcr-impr-branch branch 3 times, most recently from a670f83 to 5637863 Compare December 2, 2024 12:26
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 54.38596% with 52 lines in your changes missing coverage. Please review.

Project coverage is 56.39%. Comparing base (9095d8d) to head (f1420ad).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/identity/oauth2/util/OAuth2Util.java 45.71% 15 Missing and 4 partials ⚠️
...rg/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java 64.00% 9 Missing ⚠️
...entity/oauth/dcr/internal/DCRServiceComponent.java 0.00% 6 Missing ⚠️
...carbon/identity/oauth/dcr/service/DCRMService.java 78.57% 5 Missing and 1 partial ⚠️
...2/carbon/identity/oauth/OAuthAdminServiceImpl.java 50.00% 5 Missing and 1 partial ⚠️
...bon/identity/oauth/dcr/internal/DCRDataHolder.java 0.00% 3 Missing ⚠️
.../wso2/carbon/identity/oauth/OAuthAdminService.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2578      +/-   ##
============================================
- Coverage     56.40%   56.39%   -0.02%     
- Complexity     8269     8273       +4     
============================================
  Files           632      632              
  Lines         46680    46815     +135     
  Branches       8508     8520      +12     
============================================
+ Hits          26332    26402      +70     
- Misses        16585    16644      +59     
- Partials       3763     3769       +6     
Flag Coverage Δ
unit 38.76% <54.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thumimku
Thumimku previously approved these changes Dec 13, 2024
AnuradhaSK
AnuradhaSK previously approved these changes Dec 23, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12592991303

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12592991303
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12625902132

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12625902132
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12633558767

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12633558767
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12633558767

@ShanChathusanda93 ShanChathusanda93 merged commit 2302b85 into wso2-extensions:master Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants