Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing claims for federated users for jwt token issuers #2613

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Fix missing claims for federated users for jwt token issuers #2613

merged 10 commits into from
Dec 18, 2024

Conversation

sandushi
Copy link
Contributor

Purpose

  • Fix the issue of missing claims for federated users for jwt token issuers.
  • To get the tokenID from the access token, we need to pass the jti of the jwt tokens.
  • From this PR, the changes are done for the jwt token to extract the jti value and pass it for the getTokenIdByAccessToken to - get the token id.

Related issue

wso2/product-is#21387

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11623432184

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.36%. Comparing base (2f31dda) to head (a0bccb8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/oauth/cache/AuthorizationGrantCache.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2613      +/-   ##
============================================
- Coverage     56.41%   56.36%   -0.05%     
+ Complexity     8407     8266     -141     
============================================
  Files           632      632              
  Lines         47644    47307     -337     
  Branches       8665     8611      -54     
============================================
- Hits          26876    26665     -211     
+ Misses        16995    16854     -141     
- Partials       3773     3788      +15
Flag Coverage Δ
unit 38.80% <55.55%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sahandilshan
sahandilshan reviewed Nov 1, 2024
View reviewed changes
...entity.oauth/src/main/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCache.java Outdated Show resolved Hide resolved
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java Outdated Show resolved Hide resolved
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java Outdated Show resolved Hide resolved
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java Outdated Show resolved Hide resolved
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java Outdated Show resolved Hide resolved
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java Outdated Show resolved Hide resolved
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11623432184
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11657748364

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11657748364
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11934561217

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11934561217
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11948007129

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11948007129
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 21, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11948007129

@Thumimku
Copy link
Contributor

Hi @sandushi,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12379370934

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12379370934
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 17, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12379370934

kayathiri4
kayathiri4 reviewed Dec 18, 2024
View reviewed changes
...ty.oauth/src/test/java/org/wso2/carbon/identity/oauth/cache/AuthorizationGrantCacheTest.java
import static org.mockito.Mockito.when;


public class AuthorizationGrantCacheTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add class comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with e607ea0

@sandushi sandushi merged commit 80fc44d into wso2-extensions:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahandilshan sahandilshan sahandilshan left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@kayathiri4 kayathiri4 kayathiri4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sandushi @jenkins-is-staging @Thumimku @sahandilshan @kayathiri4