Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sub organization applications to issue tokens to access the resources in sub organizations #2616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Nov 1, 2024

Proposed changes in this pull request

When should this PR be merged

[1] #2578

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from 98ad3c9 to ecb8ca8 Compare November 1, 2024 19:58
@Thumimku
Copy link
Contributor

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

@ShanChathusanda93
Copy link
Contributor Author

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

This PR is WIP and will be completed withing next couple of days.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch 4 times, most recently from 08e2154 to 5b0bb86 Compare January 20, 2025 20:20
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from 5b0bb86 to 388a274 Compare January 21, 2025 12:18
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 25.16556% with 113 lines in your changes missing coverage. Please review.

Project coverage is 55.41%. Comparing base (32cb723) to head (1148fcb).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...arbon/identity/oauth2/token/AccessTokenIssuer.java 0.00% 14 Missing ⚠️
...on/identity/oauth2/dao/TokenManagementDAOImpl.java 0.00% 12 Missing ⚠️
...2/carbon/identity/oauth2/token/JWTTokenIssuer.java 35.29% 7 Missing and 4 partials ⚠️
...th2/token/handlers/grant/PasswordGrantHandler.java 15.38% 10 Missing and 1 partial ⚠️
...dlers/grant/AbstractAuthorizationGrantHandler.java 44.44% 8 Missing and 2 partials ⚠️
...org/wso2/carbon/identity/oauth2/util/JWTUtils.java 0.00% 10 Missing ⚠️
...carbon/identity/oauth2/dao/AccessTokenDAOImpl.java 22.22% 6 Missing and 1 partial ⚠️
...org/wso2/carbon/identity/oauth2/OAuth2Service.java 50.00% 5 Missing and 1 partial ⚠️
...t/authentication/BasicAuthClientAuthenticator.java 40.00% 5 Missing and 1 partial ⚠️
...client/authentication/OAuthClientAuthnService.java 25.00% 5 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2616      +/-   ##
============================================
- Coverage     55.79%   55.41%   -0.38%     
+ Complexity     8446     8382      -64     
============================================
  Files           632      631       -1     
  Lines         48587    49787    +1200     
  Branches       9300     9639     +339     
============================================
+ Hits          27109    27590     +481     
- Misses        17601    18250     +649     
- Partials       3877     3947      +70     
Flag Coverage Δ
unit 38.69% <25.16%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch 3 times, most recently from ba05db7 to 94351a4 Compare January 22, 2025 09:50
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from ff9bac9 to 1148fcb Compare January 22, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants