Reducing the token synchronize weight for existing tokens #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2660 +/- ##
============================================
- Coverage 56.39% 55.75% -0.64%
- Complexity 8267 8415 +148
============================================
Files 632 632
Lines 46681 48509 +1828
Branches 8508 8968 +460
============================================
+ Hits 26324 27047 +723
- Misses 16592 17615 +1023
- Partials 3765 3847 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thumimku
reviewed
Jan 8, 2025
| Additionally, this segment should strictly avoid any write or update operations. | ||
| It was introduced to minimize traffic at the token issuance lock for certain token requests. | ||
| */ | ||
| if (!(JWT.equalsIgnoreCase(tokenType) && getRenewWithoutRevokingExistingStatus() && |
There was a problem hiding this comment.
Apart from "Default" and "JWT", token type there can be custom token types too, won't there any issue with this logic?
There was a problem hiding this comment.
Given that only two types of token issuer classes implement OauthTokenIssuer interface in this repo, how come custom token flow exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
The synchronize block at the token issuance path seems to lock read only flow, where issuing existing token. For readonly flow, there is no requirement of a synchronize lock. This refactoring reduces the traffic at the synchronized block.
When should this PR be merged
After approval of the Authorization product team and the product owner.
Follow up actions
PR builder test success and QA approval.