Add support to connect to the LoginFlow AI service #5971

sahandilshan · 2024-09-30T10:27:50Z

Proposed changes in this pull request

With this PR, the product-is will be able to connect the loginflow AI microservice and generate AI results accordingly

Related Issue(s)

AI-Powered Login Flow feature product-is#20040

CLAassistant · 2024-09-30T10:27:55Z

All committers have signed the CLA.

components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java

...n.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAITokenService.java

pamodaaw · 2024-10-18T08:44:09Z

...cation.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManager.java

@@ -0,0 +1,23 @@
+package org.wso2.carbon.identity.application.mgt.ai;


missing copywrite text

pamodaaw · 2024-10-18T08:54:23Z

features/ai-services-mgt/pom.xml

+        <module>org.wso2.carbon.ai.service.mgt.server.feature</module>
+    </modules>
+
+</project>


Missing new line

features/ai-services-mgt/pom.xml

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml

codecov · 2024-10-18T08:59:44Z

Codecov Report

Attention: Patch coverage is 77.50000% with 54 lines in your changes missing coverage. Please review.

Project coverage is 40.71%. Comparing base (fb21729) to head (d928d9a).
Report is 28 commits behind head on master.

Files with missing lines	Patch %	Lines
...ity/application/mgt/ai/LoginFlowAIManagerImpl.java	0.00%	19 Missing ⚠️
...lication/mgt/ai/constant/LoginFlowAIConstants.java	0.00%	17 Missing ⚠️
...bon/ai/service/mgt/token/AIAccessTokenManager.java	88.63%	4 Missing and 6 partials ⚠️
...2/carbon/ai/service/mgt/util/AIHttpClientUtil.java	91.89%	3 Missing and 3 partials ⚠️
...2/carbon/ai/service/mgt/constants/AIConstants.java	93.33%	1 Missing ⚠️
...nternal/ApplicationManagementServiceComponent.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5971      +/-   ##
============================================
- Coverage     40.88%   40.71%   -0.17%     
- Complexity    14516    14601      +85     
============================================
  Files          1772     1781       +9     
  Lines        117769   118681     +912     
  Branches      19116    20275    +1159     
============================================
+ Hits          48146    48321     +175     
- Misses        62316    63053     +737     
  Partials       7307     7307

Flag	Coverage Δ
unit	`25.32% <77.50%> (+0.24%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

features/ai-services-mgt/org.wso2.carbon.ai.service.mgt.server.feature/pom.xml

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

sonarqubecloud · 2024-11-15T12:02:04Z

Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud

omindu · 2024-11-28T08:53:14Z

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml

+                            org.apache.http.concurrent; version="${httpcore.version.osgi.import.range}",
+                        </Import-Package>
+                        <Export-Package>
+                            org.wso2.carbon.ai.service.mgt.*; version="${carbon.identity.package.export.version}"


Export only the necessary packages. Refer https://github.com/wso2-extensions/identity-organization-management/pull/415/files#diff-14b084926843894a0c5ada151f6e58de555097d5fb869d352a4a0c4e75986153R116-R124

omindu · 2024-11-28T09:23:51Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+    private AccessTokenRequestHelper createDefaultHelper() {
+
+        return new AccessTokenRequestHelper(LOGIN_FLOW_AI_KEY, LOGIN_FLOW_AI_TOKEN_ENDPOINT,
+                HttpAsyncClients.createDefault());


Can we use connection pooling here ?

sahandilshan · 2024-11-28T08:53:14Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+    private static volatile AIAccessTokenManager instance;  // Volatile for thread safety.
+    private static final Object lock = new Object();  // Lock for synchronization.


Check if we want to change the naming

sahandilshan · 2024-11-28T08:53:42Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+    private String clientId;
+
+    private AIAccessTokenManager() {
+        // Prevent from initialization.


Remove comment

sahandilshan · 2024-11-28T09:00:44Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+        private final String key;
+        private final String aiServiceTokenEndpoint;
+        private static final int MAX_RETRIES = IdentityUtil.getProperty(
+                "AIServices.LoginFlow.TokenRequestMaxRetries") != null ?


Remove LoginFlow config since this a common component

sahandilshan · 2024-11-28T09:01:41Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+        private final String aiServiceTokenEndpoint;
+        private static final int MAX_RETRIES = IdentityUtil.getProperty(
+                "AIServices.LoginFlow.TokenRequestMaxRetries") != null ?
+                Integer.parseInt(IdentityUtil.getProperty("AIServices.LoginFlow.TokenRequestMaxRetries")) : 3;


Use constants

sahandilshan · 2024-11-28T09:02:00Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+        private static final int MAX_RETRIES = IdentityUtil.getProperty(
+                "AIServices.LoginFlow.TokenRequestMaxRetries") != null ?
+                Integer.parseInt(IdentityUtil.getProperty("AIServices.LoginFlow.TokenRequestMaxRetries")) : 3;
+        private static final long TIMEOUT = IdentityUtil.getProperty(


Move these into a method

sahandilshan · 2024-11-28T09:06:14Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                    post.setHeader("Content-Type", "application/x-www-form-urlencoded");
+
+                    StringEntity entity = new StringEntity("grant_type=client_credentials");
+                    entity.setContentType(new BasicHeader(HTTP.CONTENT_TYPE, "application/x-www-form-urlencoded"));


Use constants for headers (There should be reusable constants

sahandilshan · 2024-11-28T09:14:31Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                    post.setEntity(entity);
+
+                    CountDownLatch latch = new CountDownLatch(1);
+                    final String[] accessToken = new String[1];


***NOTE: What should we do in multi node setup, should we use multiple JWT tokens or persist the access token in DB?

sahandilshan · 2024-11-28T09:16:11Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                                if (response.getStatusLine().getStatusCode() == HttpStatus.SC_OK) {
+                                    String responseBody = EntityUtils.toString(response.getEntity());
+                                    Map<String, Object> responseMap = gson.fromJson(responseBody, Map.class);
+                                    accessToken[0] = (String) responseMap.get("access_token");


Use constants for all keys. Check all places

sahandilshan · 2024-11-28T09:20:40Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                                    // Decode the JWT to extract client ID.
+                                    String[] jwtParts = accessToken[0].split("\\.");
+                                    if (jwtParts.length == 3) {
+                                        String payloadJson = new String(Base64.getUrlDecoder().decode(jwtParts[1]),


Check if we need to decode the token also check if we actually need the token type

sahandilshan · 2024-11-28T09:21:55Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                                            response.getStatusLine().getStatusCode());
+                                }
+                            } catch (IOException | JsonSyntaxException e) {
+                                LOG.error("Error parsing token response: " + e.getMessage(), e);


Change to debug logs

…ts-sign-and-signature-validation Add util methods for signing and signature validation

…lopment iteration

Introduce SAMLSSOPersistenceManagerFactory to switch between different persistence implementation

…lopment iteration

…nd-prov-issue Revert "Revert "Fix: Unable to Update Google Connector after Configuring Outbound Provisioning for Google""

…lopment iteration

- Define constants for reusable keys - Remove token decoding and get the clientId from the AI KEY

# Conflicts: # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java # components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/util/AIHttpClientUtil.java # components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml # pom.xml

- Get tokens with token binding - Add j2 configs - Modify AIHttpUtil tests to use call mockwebserver

sonarqubecloud · 2025-01-08T07:56:51Z

Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

sahandilshan force-pushed the loginflow-ai branch from ec247a1 to e73a82c Compare October 3, 2024 11:39

sahandilshan mentioned this pull request Oct 6, 2024

Add api support to try out loginglow AI feature wso2/identity-api-server#681

Open

pamodaaw reviewed Oct 7, 2024

View reviewed changes

components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml Show resolved Hide resolved

pamodaaw reviewed Oct 7, 2024

View reviewed changes

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java Show resolved Hide resolved

pamodaaw reviewed Oct 7, 2024

View reviewed changes

sahandilshan force-pushed the loginflow-ai branch from 8ee9876 to 5367ae1 Compare October 18, 2024 08:32

pamodaaw reviewed Oct 18, 2024

View reviewed changes

features/ai-services-mgt/pom.xml Outdated Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

features/ai-services-mgt/org.wso2.carbon.ai.service.mgt.server.feature/pom.xml Outdated Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml Outdated Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java Show resolved Hide resolved

pamodaaw reviewed Oct 18, 2024

View reviewed changes

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java Outdated Show resolved Hide resolved

sahandilshan requested review from pamodaaw and ZiyamSanthosh November 15, 2024 12:01

omindu reviewed Nov 28, 2024

View reviewed changes

sahandilshan commented Nov 28, 2024

View reviewed changes

sadilchamishka and others added 3 commits December 5, 2024 07:16

Merge pull request wso2#6176 from sadilchamishka/add-utils-for-conten…

47297af

…ts-sign-and-signature-validation Add util methods for signing and signature validation

[WSO2 Release] [Jenkins #8114] [Release 7.7.21] prepare release v7.7.21

16026f4

[WSO2 Release] [Jenkins #8114] [Release 7.7.21] prepare for next deve…

ca6bc45

…lopment iteration

wso2-jenkins-bot and others added 29 commits December 20, 2024 07:56

[WSO2 Release] [Jenkins #8183] [Release 7.7.58] prepare release v7.7.58

cf1db17

[WSO2 Release] [Jenkins #8183] [Release 7.7.58] prepare for next deve…

e42bf21

…lopment iteration

Introduce maxPasswordAllowedLength config. (wso2#6182)

d1e5ee4

Introduce SAMLSSOServiceProviderDAO Factory class

7c68916

[WSO2 Release] [Jenkins #8185] [Release 7.7.59] prepare release v7.7.59

37630be

[WSO2 Release] [Jenkins #8185] [Release 7.7.59] prepare for next deve…

96a835d

…lopment iteration

Merge pull request wso2#6240 from Osara-B/saml-removal

f7352ad

Introduce SAMLSSOPersistenceManagerFactory to switch between different persistence implementation

[WSO2 Release] [Jenkins #8187] [Release 7.7.60] prepare release v7.7.60

2b4897c

[WSO2 Release] [Jenkins #8187] [Release 7.7.60] prepare for next deve…

f70492e

…lopment iteration

Merge pull request wso2#6207 from mpmadhavig/oracle-issue

4821563

[WSO2 Release] [Jenkins #8189] [Release 7.7.61] prepare release v7.7.61

510f966

[WSO2 Release] [Jenkins #8189] [Release 7.7.61] prepare for next deve…

aa26213

…lopment iteration

Merge pull request wso2#6232 from wso2/revert-6231-revert-6220-outbou…

da378db

…nd-prov-issue Revert "Revert "Fix: Unable to Update Google Connector after Configuring Outbound Provisioning for Google""

[WSO2 Release] [Jenkins #8191] [Release 7.7.62] prepare release v7.7.62

4d6ef25

[WSO2 Release] [Jenkins #8191] [Release 7.7.62] prepare for next deve…

3e7e0ce

…lopment iteration

Add support to connect to the LoginFlow AI service

45ab16e

Add AI Management component

d9e0ba2

Add ai feature component

90ae363

Add loginflow AI capability

b4df626

Bump new component version

57f6c5f

Fix code quality

ddc1733

Bump AI version to latest framework version

16e792e

Add more unit tests to cover complex scenarios

a5229cc

Bump framework version in AI components

da6360b

Fix checkstyle issues

95eef11

Add support for connection pool with other improvements

aca5555

- Define constants for reusable keys - Remove token decoding and get the clientId from the AI KEY

Modify LoginFlowAI Implementation

cdad525

Add connectiontime out support with other modifications

00b0147

- Get tokens with token binding - Add j2 configs - Modify AIHttpUtil tests to use call mockwebserver

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to connect to the LoginFlow AI service #5971

Add support to connect to the LoginFlow AI service #5971

sahandilshan commented Sep 30, 2024

CLAassistant commented Sep 30, 2024 •

edited

Loading

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

codecov bot commented Oct 18, 2024 •

edited

Loading

sonarqubecloud bot commented Nov 15, 2024

omindu Nov 28, 2024 •

edited

Loading

omindu Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sahandilshan Nov 28, 2024

sonarqubecloud bot commented Jan 8, 2025

		@@ -0,0 +1,23 @@
		package org.wso2.carbon.identity.application.mgt.ai;

		private static volatile AIAccessTokenManager instance; // Volatile for thread safety.
		private static final Object lock = new Object(); // Lock for synchronization.

Add support to connect to the LoginFlow AI service #5971

Are you sure you want to change the base?

Add support to connect to the LoginFlow AI service #5971

Conversation

sahandilshan commented Sep 30, 2024

Proposed changes in this pull request

Related Issue(s)

CLAassistant commented Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

sonarqubecloud bot commented Nov 15, 2024

Quality Gate passed

omindu Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 8, 2025

Quality Gate passed

CLAassistant commented Sep 30, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

omindu Nov 28, 2024 •

edited

Loading