Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce JDBC based persistence for SAML #6241

Closed
wants to merge 1 commit into from
Closed

Introduce JDBC based persistence for SAML #6241

wants to merge 1 commit into from
+2,129 −14

Conversation

Osara-B
Copy link
Contributor

@Osara-B Osara-B commented Dec 20, 2024 •
edited
Loading

Proposed changes in this pull request

Introduce JDBC based persistence for SAML. Related to,

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.79669% with 77 lines in your changes missing coverage. Please review.

Project coverage is 45.81%. Comparing base (7c68916) to head (67ea73b).
Report is 192 commits behind head on master.

Files with missing lines Patch % Lines
...ty/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java 86.58% 29 Missing and 13 partials ⚠️
.../identity/core/model/SAMLSSOServiceProviderDO.java 61.53% 3 Missing and 32 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6241      +/-   ##
============================================
+ Coverage     45.71%   45.81%   +0.09%     
- Complexity    14091    14465     +374     
============================================
  Files          1633     1636       +3     
  Lines        100857   104116    +3259     
  Branches      17723    18515     +792     
============================================
+ Hits          46104    47697    +1593     
- Misses        48035    49520    +1485     
- Partials       6718     6899     +181
Flag Coverage Δ
unit 28.90% <81.79%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg changed the title Introduce SAMLSSOPersistenceManagerFactory and JDBC based persistence for SAML Introduce JDBC based persistence for SAML Dec 21, 2024
UdeshAthukorala
UdeshAthukorala reviewed Dec 22, 2024
View reviewed changes
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
....core/src/main/java/org/wso2/carbon/identity/core/dao/JDBCSAMLSSOServiceProviderDAOImpl.java Outdated Show resolved Hide resolved
...ty.core/src/main/java/org/wso2/carbon/identity/core/dao/SAMLSSOServiceProviderConstants.java Outdated Show resolved Hide resolved
...carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/constant/TestConstants.java Show resolved Hide resolved
...rg.wso2.carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/util/TestUtils.java Show resolved Hide resolved
...rg.wso2.carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/util/TestUtils.java Outdated Show resolved Hide resolved
...es/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/oracle.sql Outdated Show resolved Hide resolved
...es/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/oracle.sql Outdated Show resolved Hide resolved
@Osara-B Osara-B force-pushed the saml-removal-clone branch 2 times, most recently from 9cffcfa to 8ef5602 Compare January 2, 2025 11:21
@Osara-B Osara-B force-pushed the saml-removal-clone branch from 8ef5602 to 67ea73b Compare January 7, 2025 05:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Osara-B Osara-B closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdeshAthukorala UdeshAthukorala UdeshAthukorala left review comments

@darshanasbg darshanasbg darshanasbg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Osara-B @darshanasbg @UdeshAthukorala