Unify handling of unspecified count parameters for listWithGet and listWithPost #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
klaasdellschaft
force-pushed
the
handling-unspecified-count-parameter
branch
from
e81c4bb
to
ffcc587
Compare
…stWithPost In the SCIM 2.0 spec, it says that "the maximum number of results is set by the service provider" if the count parameter is left unspecified by the user. In case of the listWithPost methods, this defaulting is already done by Charon via CharonConfiguration.getInstance().getCountValueForPagination(). However, in case of listWithGet (using Integer parameters) Charon simply passes on a null value to the implementation of e.g. UserManager, where the developer has to do the defaulting in order to comply with the SCIM 2.0 spec. In order to increase consistency in Charon's handling of the count parameter, and in order to lower the implementation effort for the developer, Charon is now doing the defaulting for listWithPut as well as for listWithGet (in case of Integer parameters).
klaasdellschaft
force-pushed
the
handling-unspecified-count-parameter
branch
from
ffcc587
to
c68fd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the SCIM 2.0 spec, it says that "the maximum number of results is set by the service provider" if the count parameter is left unspecified by the user. In case of the listWithPost methods, this defaulting is already done by Charon via CharonConfiguration.getInstance().getCountValueForPagination(). However, in case of listWithGet (using Integer parameters) Charon simply passes on a null value to the implementation of e.g. UserManager, where the developer has to do the defaulting in order to comply with the SCIM 2.0 spec. In order to increase consistency in Charon's handling of the count parameter, and in order to lower the implementation effort for the developer, Charon is now doing the defaulting for listWithPut as well as for listWithGet (in case of Integer parameters).