Enable loading the UserSchemaExtension from a classpath resource #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. a file packaged into the application's jar file The change is fully backwards compatible, i.e. the previous method signature `buildUserSchemaExtension(String configFilePath)` is still available, and it behaves the same as before. Only a new method `buildUserSchemaExtension(InputStream inputStream)` has been made available.
klaasdellschaft
force-pushed
the
allow-reading-userschemaextension-from-inputstream
branch
from
ac19301
to
11de282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using Charon in the context of a Spring Boot application, typically all resources needed by the application are packaged into the jar file together with all of the application's classes. In this case, it is not directly possible to read that classpath resource via a
FileInputStream. In order to still be able to load a UserSchemaExtension, currently a workaround would need to applied in the application, i.e. the classpath resource would need to be copied to a temporary file, and then the temporary file would need to be deleted after being loaded bySCIMUserSchemaExtensionBuilder.Goals
In order to avoid this workaround, I added a further method to
SCIMUserSchemaExtensionBuilderwhich it loads the schema from anyInputStream. When using this newly introduced method, the application is responsible for opening and closing that stream (and handling the exceptions that may appear during opening and closing).The solution is fully backwards compatible, i.e. the previous method signature
buildUserSchemaExtension(String configFilePath)is still available, and it behaves the same as before. Only a new methodbuildUserSchemaExtension(InputStream inputStream)has been made available.