Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Swap Role Error Response and SCIM Type #404

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KD23243
Copy link

@KD23243 KD23243 commented Jun 26, 2024

Purpose

Resolves the issue #19746 where the error message for role creation is not properly displayed when the role name starts with "system_".

Goals

Provide clear and accurate error messages when attempting to create roles that are not permitted.

Approach

The error detail was incorrectly placed in the scimType attribute, causing confusion and improper error reporting in the console. The solution involved swapping the scimType and error detail variables.

Samples

Screenshot 2024-06-26 at 10 45 20 AM

Security checks

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9691270067

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9691270067
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9691270067

@KD23243 KD23243 marked this pull request as draft July 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants