Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to check for a working compose file #292

Closed
wants to merge 1 commit into from

Conversation

vordimous
Copy link

Purpose

Future changes to the repo can break the compose tutorial. This test will ensure the base components are working properly.

Goals

Create more resilience for the user-facing examples of IS installs

Approach

Run IS using the docker-compose file. test that IS started by calling the health check endpoint

with:
registry: docker.wso2.com
username: ${{ secrets.WSO2_SUB_USER }}
password: ${{ secrets.WSO2_SUB_PASS }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these secrets will need to be added or I can change the keys to use existing secrets

@sahangunathilaka
Copy link

@vordimous, Thanks for the PR. This would be a useful addition in terms of maintaining the docker composer. However there are a couple of things we need to sort out before getting this merged. The things that we need to sort out are tracked through the issue [1]. Once those are sorted out we will merge the PR after re-evaluating. Furthermore, we will be closing this PR as there are alerts being generated for unmerged PRs that stand for a long time, with the aim of reopening it once the aforementioned concerns are sorted out.

[1] #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants