Avoid mutation of the plate_number public attribute #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change decouples PacBioEntity ID generation from the public Pydantic API of the class. This avoids surprising mutation of the plate_number attribute during validation. A msall number of tests checked for the mutation behaviour, so these are also changed.
Removed redundant @classmethod decorators because the Pydantic @field_validator already returns a class method. Added a constructor for improved QOL in IDEs.
|
Superseded by #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change decouples PacBioEntity ID generation from the public
Pydantic API of the class. This avoids surprising mutation of the
plate_number attribute during validation.
A small number of tests checked for the mutation behaviour, so these
are also changed.