Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #413

Open
cb0s opened this issue Mar 17, 2021 · 2 comments
Open

i18n support #413

cb0s opened this issue Mar 17, 2021 · 2 comments
Labels
👏 help wanted Extra attention is needed 🔨 enhancement New feature or request ☝️ question Further information is requested

Comments

@cb0s
Copy link
Member

cb0s commented Mar 17, 2021

What do you think about language support by the front-end?
Is it planned and if so, when will this be implemented? :)
If it is not planned what do you think about translations in general?

I know this is more relevant for the single subprojects however the core could already provide general functionality.

@cb0s cb0s added 🔨 enhancement New feature or request 👏 help wanted Extra attention is needed ☝️ question Further information is requested labels Mar 17, 2021
@fussel178
Copy link
Member

fussel178 commented Mar 17, 2021

Great question!
I personally thought about this for a while and searched around a little.

We only really need the internationalisation in the telestion-client-common package.
The telestion-client-core package only set up, arranges and renders children and app settings and provides the developer APIs to create PSCs.

After a short search, I found two interesting solutions:

  1. The built-in solution from Adobe React Aria (especially the I18nProvider component and associated hooks).
  2. The full stack internationalisation i18next with React support.

I personally tend towards the built-in solution from Adobe because it's easy to set up, well documented and has a good integration with the existing project dependencies and structure (usage in the CommonWrapper component).

@pklaschka What do you think?

@pklaschka
Copy link
Member

I've used the react-intl package before. I'm not entirely sure if one's better, more complete, etc. Let's maybe take a look at the different options and see what we want to use.

I18n, of course, is a large topic, so whatever we choose, it should probably be powerful enough so we don't have to switch later down the line.

@pklaschka pklaschka changed the title Language support i18n support Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👏 help wanted Extra attention is needed 🔨 enhancement New feature or request ☝️ question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants