Fix: Midea heat pump outside temperature issue when below zero

[erikgieseler]

Fix: Midea heat pump outside temperature issue when below zero georgezhao2010/midea_ac_lan#427

[rokam]

LGTM. Although there is a linting error to be fixed.

[wuwentao]

@erikgieseler
you may need to fix the github action error, it show the solution as below:

  -        self.outdoor_temperature = (base_value - 256) if base_value > 127 else base_value
  +        self.outdoor_temperature = (
  +            (base_value - 256) if base_value > 127 else base_value
  +        )

[wuwentao]

we can accept the changes, and port it to midea-local.

[erikgieseler]

The action errors are fixed

[chemelli74]

LGTM.

Just a small question: is that valid only for "c3" devices or there is something similar for others ?

[erikgieseler]

LGTM.

Just a small question: is that valid only for "c3" devices or there is something similar for others ?

Unfortunately, I can't answer that because I only have a C3 heat pump. Perhaps the same problem also exists with other devices where the exact same old code was used.

[chemelli74]

We need to rework the code and remove all those duplicates.
I'm nearly done with the typing, next job will be the clean-up.

[erikgieseler]

We need to rework the code and remove all those duplicates. I'm nearly done with the typing, next job will be the clean-up.

I have done a search with the old code across all other devices.
There are no duplicates that use the same code.