chore: climate typing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuwentao
approved these changes
Jun 1, 2024
caibinqing
requested changes
Jun 1, 2024
| ] | ||
|
|
||
| def __init__(self, device, entity_key, zone): | ||
| def __init__(self, device: Any, entity_key: str, zone: str) -> None: |
There was a problem hiding this comment.
Here, zone is 0 or 1, not str
There was a problem hiding this comment.
I had the doubt but then looking at the rest of the code I went for "str". Let's create a new PR to change it
| def current_temperature(self): | ||
| return None | ||
| def current_temperature(self) -> float: | ||
| return 0 |
There was a problem hiding this comment.
Returning 0 is incorrect, return type should be -> float | None
There was a problem hiding this comment.
If you want None, then we need to change the superclass as well ;-)
There was a problem hiding this comment.
caibinqing
added a commit
to caibinqing/midea_ac_lan
that referenced
this pull request
Jun 2, 2024
chemelli74
pushed a commit
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA