Gui: Use bitmask instead of three booleans in setTemporaryVisibility … #1270
Annotations
9 errors and 31 warnings
|
Cpplint
Process completed with exit code 1.
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskFeaturePick.cpp#L49
'ui_TaskFeaturePick.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskHelixParameters.cpp#L41
'ui_TaskHelixParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskLinearPatternParameters.cpp#L44
'ui_TaskLinearPatternParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskMirroredParameters.cpp#L41
'ui_TaskMirroredParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskPolarPatternParameters.cpp#L54
'ui_TaskPolarPatternParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskPrimitiveParameters.cpp#L43
'ui_TaskPrimitiveParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp#L40
'ui_TaskRevolutionParameters.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy
Process completed with exit code 1.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.cpp#L47
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.cpp#L213
Add #include <string> for string [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.cpp#L213
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.h#L24
#ifndef header guard has wrong style, please use: SRC_GUI_VIEWPROVIDERCOORDINATESYSTEM_H_ [build/header_guard] [5]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.h#L120
#endif line should be "#endif // SRC_GUI_VIEWPROVIDERCOORDINATESYSTEM_H_" [build/header_guard] [5]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.h#L104
Add #include <string> for string [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.h#L104
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Gui/ViewProviderCoordinateSystem.h#L113
Add #include <map> for map<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Mod/PartDesign/Gui/TaskFeaturePick.cpp#L54
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/Mod/PartDesign/Gui/TaskFeaturePick.cpp#L55
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1021
Pass small and trivially-copyable type by value (const Py_complex &) [-Wclazy-function-args-by-value]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1088
Py::seqref has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1437
Py::SeqBase::iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1596
Py::SeqBase::const_iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L2932
Py::MapBase::iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L2970
Missing reference on non-trivial type (class Py::List) [-Wclazy-function-args-by-ref]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3051
Py::MapBase::const_iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3075
Missing reference on non-trivial type (class Py::List) [-Wclazy-function-args-by-ref]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3542
Pass small and trivially-copyable type by value (const class Py::BaseException &) [-Wclazy-function-args-by-value]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3553
Pass small and trivially-copyable type by value (const class Py::BaseException &) [-Wclazy-function-args-by-value]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.cpp#L60
'pcGroupChildren' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.cpp#L95
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.cpp#L156
25 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.cpp#L213
all parameters should be named in a function [readability-named-parameter]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.cpp#L226
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.h#L39
enum 'DatumElement' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.h#L50
class 'ViewProviderCoordinateSystem' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.h#L97
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.h#L103
all parameters should be named in a function [readability-named-parameter]
|
|
Clang-tidy:
src/Gui/ViewProviderCoordinateSystem.h#L104
all parameters should be named in a function [readability-named-parameter]
|
Loading