Core: Fixes #18717 #1274
Annotations
2 errors and 42 warnings
|
Black (Python)
Process completed with exit code 1.
|
|
Cpplint
Process completed with exit code 1.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Black (Python):
src/Mod/Test/Document.py#L1
would reformat src/Mod/Test/Document.py
|
|
Pylint:
src/Mod/Test/Document.py#L234
Line too long (114/100) (line-too-long)
|
|
Pylint:
src/Mod/Test/Document.py#L958
Line too long (113/100) (line-too-long)
|
|
Pylint:
src/Mod/Test/Document.py#L1719
Line too long (101/100) (line-too-long)
|
|
Pylint:
src/Mod/Test/Document.py#L2336
Line too long (108/100) (line-too-long)
|
|
Pylint:
src/Mod/Test/Document.py#L90
FIXME: Causes somehow a ref count error but it's _not_ FreeCAD.getDocument()!!! (fixme)
|
|
Pylint:
src/Mod/Test/Document.py#L1296
FIXME: See bug #1820554 (fixme)
|
|
Pylint:
src/Mod/Test/Document.py#L1
Missing module docstring (missing-module-docstring)
|
|
Pylint:
src/Mod/Test/Document.py#L24
Multiple imports on one line (FreeCAD, os, unittest, tempfile) (multiple-imports)
|
|
Pylint:
src/Mod/Test/Document.py#L34
Missing class docstring (missing-class-docstring)
|
|
Pylint:
src/Mod/Test/Document.py#L47
Missing class docstring (missing-class-docstring)
|
|
Cpplint:
src/App/Datums.cpp#L39
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/App/Datums.cpp#L213
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
|
Cpplint:
src/App/Datums.cpp#L291
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/App/Datums.cpp#L304
Add #include <set> for set<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/App/Datums.h#L24
#ifndef header guard has wrong style, please use: SRC_APP_DATUMS_H_ [build/header_guard] [5]
|
|
Cpplint:
src/App/Datums.h#L265
#endif line should be "#endif // SRC_APP_DATUMS_H_" [build/header_guard] [5]
|
|
Cpplint:
src/App/Datums.h#L49
Constructors callable with one argument should be marked explicit. [runtime/explicit] [4]
|
|
Cpplint:
src/App/Datums.h#L202
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
|
|
Cpplint:
src/App/Datums.h#L230
Is this a non-const reference? If so, make const or use a pointer: App::PropertyLink& featProp [runtime/references] [2]
|
|
Cpplint:
src/App/Datums.h#L255
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1021
Pass small and trivially-copyable type by value (const Py_complex &) [-Wclazy-function-args-by-value]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1088
Py::seqref has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1437
Py::SeqBase::iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L1596
Py::SeqBase::const_iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L2932
Py::MapBase::iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L2970
Missing reference on non-trivial type (class Py::List) [-Wclazy-function-args-by-ref]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3051
Py::MapBase::const_iterator has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3075
Missing reference on non-trivial type (class Py::List) [-Wclazy-function-args-by-ref]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3542
Pass small and trivially-copyable type by value (const class Py::BaseException &) [-Wclazy-function-args-by-value]
|
|
Clazy:
src/CXX/Python3/Objects.hxx#L3553
Pass small and trivially-copyable type by value (const class Py::BaseException &) [-Wclazy-function-args-by-value]
|
|
Clang-tidy:
src/App/Datums.cpp#L50
avoid do-while loops [cppcoreguidelines-avoid-do-while]
|
|
Clang-tidy
note: expanded from macro 'ADD_PROPERTY_TYPE'
|
|
Clang-tidy
note: expanded from macro '_ADD_PROPERTY_TYPE'
|
|
Clang-tidy:
src/App/Datums.cpp#L133
avoid do-while loops [cppcoreguidelines-avoid-do-while]
|
|
Clang-tidy
note: expanded from macro 'ADD_PROPERTY_TYPE'
|
|
Clang-tidy
note: expanded from macro '_ADD_PROPERTY_TYPE'
|
|
Clang-tidy:
src/App/Datums.cpp#L286
avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
|
|
Clang-tidy:
src/App/Datums.cpp#L293
loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
|
|
Clang-tidy:
src/App/Datums.cpp#L294
'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation]
|
|
Clang-tidy:
src/App/Datums.cpp#L352
qualified name 'App::GroupExtension::initExtension' refers to a member overridden in subclass; did you mean 'App::GeoFeatureGroupExtension'? [bugprone-parent-virtual-call]
|
Loading