clang-tidy: implementing some suggestions

src/autogain.cpp

@@ -29,6 +29,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/bass_loudness.cpp

@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/compressor.cpp

@@ -26,7 +26,12 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
+#include "util.hpp"
 
 Compressor::Compressor(const std::string& tag,
                        const std::string& schema,
@@ -174,7 +179,7 @@ void Compressor::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/crossfeed.cpp

@@ -26,6 +26,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/crystalizer.cpp

@@ -243,7 +243,7 @@ void Crystalizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/deepfilternet.cpp

@@ -24,6 +24,10 @@
 #include <span>
 #include <string>
 #include <vector>
+#include "ladspa_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
+#include "resampler.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/deesser.cpp

@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/delay.cpp

@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -113,7 +116,7 @@ void Delay::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/echo_canceller.cpp

@@ -31,6 +31,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -185,7 +187,7 @@ void EchoCanceller::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/equalizer.cpp

@@ -18,6 +18,7 @@
  */
 
 #include "equalizer.hpp"
+#include <bits/basic_string.h>
 #include <gio/gio.h>
 #include <glib-object.h>
 #include <glib.h>
@@ -29,6 +30,9 @@
 #include <string>
 #include <utility>
 #include <vector>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_equalizer.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
@@ -263,7 +267,7 @@ void Equalizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/expander.cpp

@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -165,7 +169,7 @@ void Expander::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/filter.cpp

@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 

src/gate.cpp

@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -164,7 +168,7 @@ void Gate::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/limiter.cpp

@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -148,7 +152,7 @@ void Limiter::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/loudness.cpp

@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -107,7 +110,7 @@ void Loudness::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/maximizer.cpp

@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -116,7 +119,7 @@ void Maximizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/multiband_compressor.cpp

@@ -27,6 +27,10 @@
 #include <span>
 #include <string>
 #include <utility>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -130,7 +134,7 @@ void MultibandCompressor::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/multiband_compressor_band_box.cpp

@@ -18,6 +18,24 @@
  */
 
 #include "multiband_compressor_band_box.hpp"
+#define FMT_HEADER_ONLY
+#include <fmt/core.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkcheckbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtklabel.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtktogglebutton.h>
+#include <vector>
+#include "tags_multiband_compressor.hpp"
+#include "tags_resources.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::multiband_compressor_band_box {
 

src/multiband_gate.cpp

@@ -27,6 +27,10 @@
 #include <span>
 #include <string>
 #include <utility>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -130,7 +134,7 @@ void MultibandGate::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/multiband_gate_band_box.cpp

@@ -18,6 +18,24 @@
  */
 
 #include "multiband_gate_band_box.hpp"
+#define FMT_HEADER_ONLY
+#include <fmt/core.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkcheckbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtklabel.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtktogglebutton.h>
+#include <vector>
+#include "tags_multiband_gate.hpp"
+#include "tags_resources.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::multiband_gate_band_box {
 

src/pitch.cpp

@@ -28,6 +28,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -300,7 +302,7 @@ void Pitch::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }

src/preferences_spectrum.cpp

@@ -18,6 +18,21 @@
  */
 
 #include "preferences_spectrum.hpp"
+#include <adwaita.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkcolordialogbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtkswitch.h>
+#include <vector>
+#include "tags_resources.hpp"
+#include "tags_schema.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::preferences::spectrum {
 

src/resampler.cpp

@@ -18,6 +18,7 @@
  */
 
 #include "resampler.hpp"
+#include <samplerate.h>
 
 Resampler::Resampler(const int& input_rate, const int& output_rate) : output(1, 0) {
   resample_ratio = static_cast<double>(output_rate) / static_cast<double>(input_rate);

src/rnnoise.cpp

@@ -272,7 +272,7 @@ void RNNoise::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }