From 0b3807537e822be14797be07798b370dbe98c748 Mon Sep 17 00:00:00 2001
From: wwmm <wellingtonwallace@gmail.com>
Date: Sat, 9 Mar 2024 18:28:36 -0300
Subject: [PATCH] clang-tidy: implementing some suggestions

---
 src/autogain.cpp                      |  2 ++
 src/bass_loudness.cpp                 |  3 +++
 src/compressor.cpp                    |  7 ++++++-
 src/crossfeed.cpp                     |  2 ++
 src/crystalizer.cpp                   |  2 +-
 src/deepfilternet.cpp                 |  4 ++++
 src/deesser.cpp                       |  3 +++
 src/delay.cpp                         |  5 ++++-
 src/echo_canceller.cpp                |  4 +++-
 src/equalizer.cpp                     |  6 +++++-
 src/expander.cpp                      |  6 +++++-
 src/filter.cpp                        |  3 +++
 src/gate.cpp                          |  6 +++++-
 src/limiter.cpp                       |  6 +++++-
 src/loudness.cpp                      |  5 ++++-
 src/maximizer.cpp                     |  5 ++++-
 src/multiband_compressor.cpp          |  6 +++++-
 src/multiband_compressor_band_box.cpp | 18 ++++++++++++++++++
 src/multiband_gate.cpp                |  6 +++++-
 src/multiband_gate_band_box.cpp       | 18 ++++++++++++++++++
 src/pitch.cpp                         |  4 +++-
 src/preferences_spectrum.cpp          | 15 +++++++++++++++
 src/resampler.cpp                     |  1 +
 src/rnnoise.cpp                       |  2 +-
 src/speex.cpp                         |  2 ++
 25 files changed, 127 insertions(+), 14 deletions(-)

diff --git a/src/autogain.cpp b/src/autogain.cpp
index 6fb705f83..988e8530f 100644
--- a/src/autogain.cpp
+++ b/src/autogain.cpp
@@ -29,6 +29,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/bass_loudness.cpp b/src/bass_loudness.cpp
index bae78ced9..b51ee036a 100644
--- a/src/bass_loudness.cpp
+++ b/src/bass_loudness.cpp
@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/compressor.cpp b/src/compressor.cpp
index fefcbca16..dfd4f0b2a 100644
--- a/src/compressor.cpp
+++ b/src/compressor.cpp
@@ -26,7 +26,12 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
+#include "util.hpp"
 
 Compressor::Compressor(const std::string& tag,
                        const std::string& schema,
@@ -174,7 +179,7 @@ void Compressor::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/crossfeed.cpp b/src/crossfeed.cpp
index 2ec290679..ce9cdcd0f 100644
--- a/src/crossfeed.cpp
+++ b/src/crossfeed.cpp
@@ -26,6 +26,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/crystalizer.cpp b/src/crystalizer.cpp
index 16ba4e304..e9ae40d8e 100644
--- a/src/crystalizer.cpp
+++ b/src/crystalizer.cpp
@@ -243,7 +243,7 @@ void Crystalizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/deepfilternet.cpp b/src/deepfilternet.cpp
index 7e918a60b..694fdc70a 100644
--- a/src/deepfilternet.cpp
+++ b/src/deepfilternet.cpp
@@ -24,6 +24,10 @@
 #include <span>
 #include <string>
 #include <vector>
+#include "ladspa_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
+#include "resampler.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/deesser.cpp b/src/deesser.cpp
index ab6723d08..6e2eb3f52 100644
--- a/src/deesser.cpp
+++ b/src/deesser.cpp
@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/delay.cpp b/src/delay.cpp
index 2747c732d..416d60500 100644
--- a/src/delay.cpp
+++ b/src/delay.cpp
@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -113,7 +116,7 @@ void Delay::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/echo_canceller.cpp b/src/echo_canceller.cpp
index a40b1c8dd..529447bb0 100644
--- a/src/echo_canceller.cpp
+++ b/src/echo_canceller.cpp
@@ -31,6 +31,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -185,7 +187,7 @@ void EchoCanceller::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/equalizer.cpp b/src/equalizer.cpp
index a55326a6e..c1c9ebe25 100644
--- a/src/equalizer.cpp
+++ b/src/equalizer.cpp
@@ -18,6 +18,7 @@
  */
 
 #include "equalizer.hpp"
+#include <bits/basic_string.h>
 #include <gio/gio.h>
 #include <glib-object.h>
 #include <glib.h>
@@ -29,6 +30,9 @@
 #include <string>
 #include <utility>
 #include <vector>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_equalizer.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
@@ -263,7 +267,7 @@ void Equalizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/expander.cpp b/src/expander.cpp
index 3d507f851..c6977f6cf 100644
--- a/src/expander.cpp
+++ b/src/expander.cpp
@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -165,7 +169,7 @@ void Expander::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/filter.cpp b/src/filter.cpp
index e53e7a588..9f360a4e1 100644
--- a/src/filter.cpp
+++ b/src/filter.cpp
@@ -22,6 +22,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
diff --git a/src/gate.cpp b/src/gate.cpp
index cd0c2ba3e..c5620c56d 100644
--- a/src/gate.cpp
+++ b/src/gate.cpp
@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -164,7 +168,7 @@ void Gate::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/limiter.cpp b/src/limiter.cpp
index 1be58f83b..64fac3b6b 100644
--- a/src/limiter.cpp
+++ b/src/limiter.cpp
@@ -26,6 +26,10 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -148,7 +152,7 @@ void Limiter::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/loudness.cpp b/src/loudness.cpp
index 9a4ae18ef..83129c6f1 100644
--- a/src/loudness.cpp
+++ b/src/loudness.cpp
@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -107,7 +110,7 @@ void Loudness::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/maximizer.cpp b/src/maximizer.cpp
index d43d03511..dbd19404b 100644
--- a/src/maximizer.cpp
+++ b/src/maximizer.cpp
@@ -23,6 +23,9 @@
 #include <memory>
 #include <span>
 #include <string>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -116,7 +119,7 @@ void Maximizer::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/multiband_compressor.cpp b/src/multiband_compressor.cpp
index 5b7dfdc21..eded68a66 100644
--- a/src/multiband_compressor.cpp
+++ b/src/multiband_compressor.cpp
@@ -27,6 +27,10 @@
 #include <span>
 #include <string>
 #include <utility>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -130,7 +134,7 @@ void MultibandCompressor::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/multiband_compressor_band_box.cpp b/src/multiband_compressor_band_box.cpp
index cb60d51a3..1a901cf31 100644
--- a/src/multiband_compressor_band_box.cpp
+++ b/src/multiband_compressor_band_box.cpp
@@ -18,6 +18,24 @@
  */
 
 #include "multiband_compressor_band_box.hpp"
+#define FMT_HEADER_ONLY
+#include <fmt/core.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkcheckbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtklabel.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtktogglebutton.h>
+#include <vector>
+#include "tags_multiband_compressor.hpp"
+#include "tags_resources.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::multiband_compressor_band_box {
 
diff --git a/src/multiband_gate.cpp b/src/multiband_gate.cpp
index 5d1f177fc..fbc559bfb 100644
--- a/src/multiband_gate.cpp
+++ b/src/multiband_gate.cpp
@@ -27,6 +27,10 @@
 #include <span>
 #include <string>
 #include <utility>
+#include "lv2_wrapper.hpp"
+#include "pipe_manager.hpp"
+#include "pipe_objects.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -130,7 +134,7 @@ void MultibandGate::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/multiband_gate_band_box.cpp b/src/multiband_gate_band_box.cpp
index 59f24bc64..7779b551e 100644
--- a/src/multiband_gate_band_box.cpp
+++ b/src/multiband_gate_band_box.cpp
@@ -18,6 +18,24 @@
  */
 
 #include "multiband_gate_band_box.hpp"
+#define FMT_HEADER_ONLY
+#include <fmt/core.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkcheckbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtklabel.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtktogglebutton.h>
+#include <vector>
+#include "tags_multiband_gate.hpp"
+#include "tags_resources.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::multiband_gate_band_box {
 
diff --git a/src/pitch.cpp b/src/pitch.cpp
index ab29fc90b..b0ce0a914 100644
--- a/src/pitch.cpp
+++ b/src/pitch.cpp
@@ -28,6 +28,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"
 
@@ -300,7 +302,7 @@ void Pitch::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/preferences_spectrum.cpp b/src/preferences_spectrum.cpp
index b4eaf9357..0e4f97df3 100644
--- a/src/preferences_spectrum.cpp
+++ b/src/preferences_spectrum.cpp
@@ -18,6 +18,21 @@
  */
 
 #include "preferences_spectrum.hpp"
+#include <adwaita.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <gobject/gobject.h>
+#include <gtk/gtk.h>
+#include <gtk/gtkcolordialogbutton.h>
+#include <gtk/gtkdropdown.h>
+#include <gtk/gtkspinbutton.h>
+#include <gtk/gtkswitch.h>
+#include <vector>
+#include "tags_resources.hpp"
+#include "tags_schema.hpp"
+#include "ui_helpers.hpp"
+#include "util.hpp"
 
 namespace ui::preferences::spectrum {
 
diff --git a/src/resampler.cpp b/src/resampler.cpp
index 7435673a5..29728c2ab 100644
--- a/src/resampler.cpp
+++ b/src/resampler.cpp
@@ -18,6 +18,7 @@
  */
 
 #include "resampler.hpp"
+#include <samplerate.h>
 
 Resampler::Resampler(const int& input_rate, const int& output_rate) : output(1, 0) {
   resample_ratio = static_cast<double>(output_rate) / static_cast<double>(input_rate);
diff --git a/src/rnnoise.cpp b/src/rnnoise.cpp
index c0a86a48c..ec6b60165 100644
--- a/src/rnnoise.cpp
+++ b/src/rnnoise.cpp
@@ -272,7 +272,7 @@ void RNNoise::process(std::span<float>& left_in,
 
     util::debug(log_tag + name + " latency: " + util::to_string(latency_value, "") + " s");
 
-    util::idle_add([=, this]() {
+    util::idle_add([this]() {
       if (!post_messages || latency.empty()) {
         return;
       }
diff --git a/src/speex.cpp b/src/speex.cpp
index cd210c045..e4b24e1da 100644
--- a/src/speex.cpp
+++ b/src/speex.cpp
@@ -28,6 +28,8 @@
 #include <mutex>
 #include <span>
 #include <string>
+#include "pipe_manager.hpp"
+#include "plugin_base.hpp"
 #include "tags_plugin_name.hpp"
 #include "util.hpp"