clang-tidy: implementing some suggestions

wwmm · Mar 9, 2024 · 31c9452 · 31c9452
1 parent 7e46d47
commit 31c9452
Show file tree

Hide file tree

Showing 32 changed files with 162 additions and 55 deletions.
diff --git a/include/effects_box.hpp b/include/effects_box.hpp
@@ -20,15 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
+#include <glib-object.h>
+#include <glibconfig.h>
 #include <gsl/gsl_spline.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkicontheme.h>
 #include "application.hpp"
-#include "apps_box.hpp"
-#include "blocklist_menu.hpp"
-#include "chart.hpp"
-#include "effects_base.hpp"
 #include "pipeline_type.hpp"
-#include "plugins_box.hpp"
-#include "tags_resources.hpp"
 
 namespace ui::effects_box {
 

diff --git a/include/equalizer.hpp b/include/equalizer.hpp
@@ -19,7 +19,15 @@
 
 #pragma once
 
+#include <gio/gio.h>
+#include <glib.h>
+#include <sys/types.h>
+#include <cstddef>
+#include <span>
+#include <string>
 #include <utility>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 #include "tags_equalizer.hpp"
 

diff --git a/include/equalizer_band_box.hpp b/include/equalizer_band_box.hpp
@@ -20,10 +20,10 @@
 #pragma once
 
 #include <adwaita.h>
-#include <glib/gi18n.h>
-#include "tags_equalizer.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
 
 namespace ui::equalizer_band_box {
 

diff --git a/include/equalizer_preset.hpp b/include/equalizer_preset.hpp
@@ -19,8 +19,10 @@
 
 #pragma once
 
+#include <gio/gio.h>
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
-#include "tags_equalizer.hpp"
+#include "preset_type.hpp"
 
 class EqualizerPreset : public PluginPresetBase {
  public:

diff --git a/include/equalizer_ui.hpp b/include/equalizer_ui.hpp
@@ -26,7 +26,7 @@
 #include <memory>
 #include <string>
 #include "application.hpp"
-#include "effects_base.hpp"
+#include "equalizer.hpp"
 
 namespace ui::equalizer_box {
 

diff --git a/include/exciter.hpp b/include/exciter.hpp
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include <sigc++/signal.h>
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Exciter : public PluginBase {

diff --git a/include/exciter_preset.hpp b/include/exciter_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class ExciterPreset : public PluginPresetBase {
  public:

diff --git a/include/exciter_ui.hpp b/include/exciter_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "exciter.hpp"
 
 namespace ui::exciter_box {
 

diff --git a/include/expander.hpp b/include/expander.hpp
@@ -19,6 +19,13 @@
 
 #pragma once
 
+#include <pipewire/context.h>
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Expander : public PluginBase {

diff --git a/include/expander_preset.hpp b/include/expander_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class ExpanderPreset : public PluginPresetBase {
  public:

diff --git a/include/expander_ui.hpp b/include/expander_ui.hpp
@@ -20,10 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "node_info_holder.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "expander.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::expander_box {
 

diff --git a/include/filter.hpp b/include/filter.hpp
@@ -19,6 +19,9 @@
 
 #pragma once
 
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Filter : public PluginBase {

diff --git a/include/filter_preset.hpp b/include/filter_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class FilterPreset : public PluginPresetBase {
  public:

diff --git a/include/filter_ui.hpp b/include/filter_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "filter.hpp"
 
 namespace ui::filter_box {
 

diff --git a/include/fir_filter_bandpass.hpp b/include/fir_filter_bandpass.hpp
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <string>
 #include "fir_filter_base.hpp"
 
 class FirFilterBandpass : public FirFilterBase {

diff --git a/include/fir_filter_base.hpp b/include/fir_filter_base.hpp
@@ -19,11 +19,12 @@
 
 #pragma once
 
+#include <sys/types.h>
 #include <zita-convolver.h>
 #include <algorithm>
-#include <numbers>
-#include <ranges>
 #include <span>
+#include <string>
+#include <vector>
 #include "util.hpp"
 
 class FirFilterBase {

diff --git a/include/fir_filter_highpass.hpp b/include/fir_filter_highpass.hpp
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <string>
 #include "fir_filter_base.hpp"
 
 class FirFilterHighpass : public FirFilterBase {

diff --git a/include/fir_filter_lowpass.hpp b/include/fir_filter_lowpass.hpp
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <string>
 #include "fir_filter_base.hpp"
 
 class FirFilterLowpass : public FirFilterBase {

diff --git a/include/gate.hpp b/include/gate.hpp
@@ -19,6 +19,13 @@
 
 #pragma once
 
+#include <pipewire/context.h>
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Gate : public PluginBase {

diff --git a/include/gate_preset.hpp b/include/gate_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class GatePreset : public PluginPresetBase {
  public:

diff --git a/include/gate_ui.hpp b/include/gate_ui.hpp
@@ -20,10 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "node_info_holder.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "gate.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::gate_box {
 

diff --git a/include/ladspa_wrapper.hpp b/include/ladspa_wrapper.hpp
@@ -20,14 +20,17 @@
 #pragma once
 
 #include <dlfcn.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
 #include <ladspa.h>
-#include <cassert>
-#include <cstring>
+#include <sys/types.h>
+#include <cmath>
+#include <limits>
 #include <span>
 #include <string>
 #include <tuple>
 #include <unordered_map>
-#include "config.h"
 #include "string_literal_wrapper.hpp"
 #include "util.hpp"
 

diff --git a/include/level_meter_preset.hpp b/include/level_meter_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class LevelMeterPreset : public PluginPresetBase {
  public:

diff --git a/include/level_meter_ui.hpp b/include/level_meter_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
 #include "level_meter.hpp"
-#include "ui_helpers.hpp"
 
 namespace ui::level_meter_box {
 

diff --git a/include/limiter.hpp b/include/limiter.hpp
@@ -19,6 +19,13 @@
 
 #pragma once
 
+#include <pipewire/context.h>
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Limiter : public PluginBase {

diff --git a/include/limiter_preset.hpp b/include/limiter_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class LimiterPreset : public PluginPresetBase {
  public:

diff --git a/include/limiter_ui.hpp b/include/limiter_ui.hpp
@@ -20,10 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "node_info_holder.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "limiter.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::limiter_box {
 

diff --git a/include/loudness.hpp b/include/loudness.hpp
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Loudness : public PluginBase {

diff --git a/include/loudness_preset.hpp b/include/loudness_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class LoudnessPreset : public PluginPresetBase {
  public:

diff --git a/include/loudness_ui.hpp b/include/loudness_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "loudness.hpp"
 
 namespace ui::loudness_box {