clang-tidy: implementing some suggestions

include/app_info.hpp

@@ -19,11 +19,17 @@
 
 #pragma once
 
+#include <STTypes.h>
 #include <adwaita.h>
 #include <fmt/core.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkicontheme.h>
+#include <unordered_map>
 #include "application.hpp"
-#include "node_info_holder.hpp"  // IWYU pragma: export
-#include "tags_resources.hpp"    // IWYU pragma: export
+#include "pipe_objects.hpp"
 
 namespace ui::app_info {
 

include/application_ui.hpp

@@ -20,6 +20,9 @@
 #pragma once
 
 #include <adwaita.h>
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glibconfig.h>
 
 namespace ui::application_window {
 

include/apps_box.hpp

@@ -20,11 +20,10 @@
 #pragma once
 
 #include <adwaita.h>
-#include <algorithm>
-#include <ranges>
-#include <string>
-#include <unordered_map>
-#include "app_info.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <gtk/gtkicontheme.h>
 #include "application.hpp"
 #include "pipeline_type.hpp"
 

include/autogain_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class AutoGainPreset : public PluginPresetBase {
  public:

include/autogain_ui.hpp

@@ -20,7 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "autogain.hpp"
 
 namespace ui::autogain_box {
 

include/bass_enhancer_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class BassEnhancerPreset : public PluginPresetBase {
  public:

include/bass_enhancer_ui.hpp

@@ -20,7 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "bass_enhancer.hpp"
 
 namespace ui::bass_enhancer_box {
 

include/bass_loudness_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class BassLoudnessPreset : public PluginPresetBase {
  public:

include/bass_loudness_ui.hpp

@@ -20,7 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "bass_loudness.hpp"
 
 namespace ui::bass_loudness_box {
 

include/blocklist_menu.hpp

@@ -20,7 +20,9 @@
 #pragma once
 
 #include <adwaita.h>
-#include <string>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkpopover.h>
 #include "application.hpp"
 #include "pipeline_type.hpp"
 

include/client_info_holder.hpp

@@ -19,8 +19,12 @@
 
 #pragma once
 
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gobject/gobject.h>
 #include <gtk/gtk.h>
-#include "pipe_manager.hpp"
+#include <sigc++/signal.h>
+#include "pipe_objects.hpp"
 
 namespace ui::holders {
 

include/compressor.hpp

@@ -20,6 +20,7 @@
 #pragma once
 
 #include <pipewire/context.h>
+#include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
 #include <span>

include/compressor_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class CompressorPreset : public PluginPresetBase {
  public:

include/compressor_ui.hpp

@@ -20,7 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "compressor.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::compressor_box {
 

include/convolver_menu_combine.hpp

@@ -20,8 +20,10 @@
 #pragma once
 
 #include <adwaita.h>
-#include <execution>
-#include <numeric>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkpopover.h>
+#include <string>
 
 namespace ui::convolver_menu_combine {
 

include/convolver_menu_impulses.hpp

@@ -20,8 +20,11 @@
 #pragma once
 
 #include <adwaita.h>
-#include <filesystem>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkpopover.h>
 #include <sndfile.hh>
+#include <string>
 #include "application.hpp"
 
 namespace ui::convolver_menu_impulses {

include/convolver_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class ConvolverPreset : public PluginPresetBase {
  public:

include/convolver_ui.hpp

@@ -21,13 +21,14 @@
 
 #include <adwaita.h>
 #include <fftw3.h>
+#include <glib-object.h>
+#include <glibconfig.h>
 #include <gsl/gsl_spline.h>
-#include <algorithm>
-#include <mutex>
-#include <numbers>
-#include <ranges>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
 #include "application.hpp"
-#include "effects_base.hpp"
+#include "convolver.hpp"
 
 namespace ui::convolver_box {
 

include/convolver_ui_common.hpp

@@ -20,6 +20,8 @@
 #pragma once
 
 #include <filesystem>
+#include <string>
+#include <tuple>
 #include <vector>
 
 namespace ui::convolver {

include/crossfeed_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class CrossfeedPreset : public PluginPresetBase {
  public:

include/crossfeed_ui.hpp

@@ -25,7 +25,7 @@
 #include <gtk/gtkbox.h>
 #include <memory>
 #include <string>
-#include "effects_base.hpp"
+#include "crossfeed.hpp"
 
 namespace ui::crossfeed_box {
 

include/crystalizer_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class CrystalizerPreset : public PluginPresetBase {
  public:

include/crystalizer_ui.hpp

@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "crystalizer.hpp"
 
 namespace ui::crystalizer_box {
 

include/deepfilternet_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class DeepFilterNetPreset : public PluginPresetBase {
  public:

include/deepfilternet_ui.hpp

@@ -20,10 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
 #include "deepfilternet.hpp"
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
 
 namespace ui::deepfilternet_box {
 

include/deesser_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class DeesserPreset : public PluginPresetBase {
  public:

include/deesser_ui.hpp

@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "deesser.hpp"
 
 namespace ui::deesser_box {
 

include/delay.hpp

@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Delay : public PluginBase {

include/delay_preset.hpp

@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class DelayPreset : public PluginPresetBase {
  public:

include/delay_ui.hpp

@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "delay.hpp"
 
 namespace ui::delay_box {
 

include/echo_canceller.hpp

@@ -20,11 +20,16 @@
 #pragma once
 
 #include <speex/speex_echo.h>
-#include <deque>
-#include <numeric>
+#include <climits>
+#include <span>
+#include <string>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 #include <speex/speex_preprocess.h>
+#include <speex/speexdsp_config_types.h>
+#include <sys/types.h>
 
 class EchoCanceller : public PluginBase {
  public: