clang-tidy: implementing some suggestions

wwmm · Mar 9, 2024 · ad7df8e · ad7df8e
1 parent 31c9452
commit ad7df8e
Show file tree

Hide file tree

Showing 41 changed files with 179 additions and 68 deletions.
diff --git a/include/maximizer.hpp b/include/maximizer.hpp
@@ -19,6 +19,11 @@
 
 #pragma once
 
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Maximizer : public PluginBase {

diff --git a/include/maximizer_preset.hpp b/include/maximizer_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class MaximizerPreset : public PluginPresetBase {
  public:

diff --git a/include/maximizer_ui.hpp b/include/maximizer_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "maximizer.hpp"
 
 namespace ui::maximizer_box {
 

diff --git a/include/module_info_holder.hpp b/include/module_info_holder.hpp
@@ -19,8 +19,12 @@
 
 #pragma once
 
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gobject/gobject.h>
 #include <gtk/gtk.h>
-#include "pipe_manager.hpp"
+#include <sigc++/signal.h>
+#include "pipe_objects.hpp"
 
 namespace ui::holders {
 

diff --git a/include/multiband_compressor.hpp b/include/multiband_compressor.hpp
@@ -19,6 +19,19 @@
 
 #pragma once
 
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <pipewire/context.h>
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <array>
+#include <cstddef>
+#include <span>
+#include <string>
+#include <utility>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 #include "tags_multiband_compressor.hpp"
 

diff --git a/include/multiband_compressor_band_box.hpp b/include/multiband_compressor_band_box.hpp
@@ -20,10 +20,11 @@
 #pragma once
 
 #include <adwaita.h>
+#include <gio/gio.h>
+#include <glib-object.h>
 #include <glib/gi18n.h>
-#include "tags_multiband_compressor.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
 
 namespace ui::multiband_compressor_band_box {
 

diff --git a/include/multiband_compressor_preset.hpp b/include/multiband_compressor_preset.hpp
@@ -19,7 +19,10 @@
 
 #pragma once
 
+#include <sys/types.h>
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 #include "tags_multiband_compressor.hpp"
 
 class MultibandCompressorPreset : public PluginPresetBase {

diff --git a/include/multiband_compressor_ui.hpp b/include/multiband_compressor_ui.hpp
@@ -20,11 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "multiband_compressor_band_box.hpp"
-#include "node_info_holder.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "multiband_compressor.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::multiband_compressor_box {
 

diff --git a/include/multiband_gate.hpp b/include/multiband_gate.hpp
@@ -19,6 +19,19 @@
 
 #pragma once
 
+#include <gio/gio.h>
+#include <glib-object.h>
+#include <glib.h>
+#include <pipewire/context.h>
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <array>
+#include <cstddef>
+#include <span>
+#include <string>
+#include <utility>
+#include <vector>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 #include "tags_multiband_gate.hpp"
 

diff --git a/include/multiband_gate_band_box.hpp b/include/multiband_gate_band_box.hpp
@@ -20,10 +20,11 @@
 #pragma once
 
 #include <adwaita.h>
+#include <gio/gio.h>
+#include <glib-object.h>
 #include <glib/gi18n.h>
-#include "tags_multiband_gate.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
 
 namespace ui::multiband_gate_band_box {
 

diff --git a/include/multiband_gate_preset.hpp b/include/multiband_gate_preset.hpp
@@ -19,7 +19,10 @@
 
 #pragma once
 
+#include <sys/types.h>
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 #include "tags_multiband_gate.hpp"
 
 class MultibandGatePreset : public PluginPresetBase {

diff --git a/include/multiband_gate_ui.hpp b/include/multiband_gate_ui.hpp
@@ -20,11 +20,13 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "multiband_gate_band_box.hpp"
-#include "node_info_holder.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "multiband_gate.hpp"
+#include "pipe_manager.hpp"
 
 namespace ui::multiband_gate_box {
 

diff --git a/include/node_info_holder.hpp b/include/node_info_holder.hpp
@@ -19,8 +19,13 @@
 
 #pragma once
 
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gobject/gobject.h>
 #include <gtk/gtk.h>
-#include "pipe_manager.hpp"
+#include <sigc++/signal.h>
+#include <string>
+#include "pipe_objects.hpp"
 
 namespace ui::holders {
 

diff --git a/include/output_level.hpp b/include/output_level.hpp
@@ -19,6 +19,9 @@
 
 #pragma once
 
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class OutputLevel : public PluginBase {

diff --git a/include/pitch.hpp b/include/pitch.hpp
@@ -19,8 +19,13 @@
 
 #pragma once
 
+#include <STTypes.h>
 #include <deque>
+#include <span>
+#include <string>
+#include <vector>
 #include "SoundTouch.h"
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Pitch : public PluginBase {

diff --git a/include/pitch_preset.hpp b/include/pitch_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class PitchPreset : public PluginPresetBase {
  public:

diff --git a/include/pitch_ui.hpp b/include/pitch_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "pitch.hpp"
 
 namespace ui::pitch_box {
 

diff --git a/include/plugins_menu.hpp b/include/plugins_menu.hpp
@@ -20,13 +20,11 @@
 #pragma once
 
 #include <adwaita.h>
-#include <string>
-#include <unordered_map>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkpopover.h>
 #include "application.hpp"
 #include "pipeline_type.hpp"
-#include "tags_plugin_name.hpp"
-#include "tags_resources.hpp"
-#include "util.hpp"
 
 namespace ui::plugins_menu {
 

diff --git a/include/preferences_general.hpp b/include/preferences_general.hpp
@@ -20,12 +20,8 @@
 #pragma once
 
 #include <adwaita.h>
-#include <filesystem>
-#include <fstream>
-#include <string>
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
-#include "util.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
 
 #ifdef ENABLE_LIBPORTAL
 #include "libportal.hpp"

diff --git a/include/preferences_spectrum.hpp b/include/preferences_spectrum.hpp
@@ -20,10 +20,8 @@
 #pragma once
 
 #include <adwaita.h>
-#include "tags_resources.hpp"
-#include "tags_schema.hpp"
-#include "ui_helpers.hpp"
-#include "util.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
 
 namespace ui::preferences::spectrum {
 

diff --git a/include/preferences_window.hpp b/include/preferences_window.hpp
@@ -19,8 +19,9 @@
 
 #pragma once
 
-#include "preferences_general.hpp"
-#include "preferences_spectrum.hpp"
+#include <adwaita.h>
+#include <glib-object.h>
+#include <glibconfig.h>
 
 namespace ui::preferences::window {
 

diff --git a/include/presets_autoloading_holder.hpp b/include/presets_autoloading_holder.hpp
@@ -19,8 +19,11 @@
 
 #pragma once
 
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gobject/gobject.h>
 #include <gtk/gtk.h>
-#include "util.hpp"
+#include <string>
 
 namespace ui::holders {
 

diff --git a/include/presets_menu.hpp b/include/presets_menu.hpp
@@ -20,10 +20,11 @@
 #pragma once
 
 #include <adwaita.h>
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkpopover.h>
 #include "application.hpp"
-#include "config.h"
 #include "preset_type.hpp"
-#include "tags_resources.hpp"
 
 namespace ui::presets_menu {
 

diff --git a/include/resampler.hpp b/include/resampler.hpp
@@ -21,7 +21,6 @@
 
 #include <samplerate.h>
 #include <cmath>
-#include <span>
 #include <vector>
 
 class Resampler {

diff --git a/include/reverb.hpp b/include/reverb.hpp
@@ -19,6 +19,9 @@
 
 #pragma once
 
+#include <span>
+#include <string>
+#include "pipe_manager.hpp"
 #include "plugin_base.hpp"
 
 class Reverb : public PluginBase {

diff --git a/include/reverb_preset.hpp b/include/reverb_preset.hpp
@@ -19,7 +19,9 @@
 
 #pragma once
 
+#include <nlohmann/json_fwd.hpp>
 #include "plugin_preset_base.hpp"
+#include "preset_type.hpp"
 
 class ReverbPreset : public PluginPresetBase {
  public:

diff --git a/include/reverb_ui.hpp b/include/reverb_ui.hpp
@@ -20,9 +20,12 @@
 #pragma once
 
 #include <adwaita.h>
-#include "effects_base.hpp"
-#include "tags_resources.hpp"
-#include "ui_helpers.hpp"
+#include <glib-object.h>
+#include <glibconfig.h>
+#include <gtk/gtkbox.h>
+#include <memory>
+#include <string>
+#include "reverb.hpp"
 
 namespace ui::reverb_box {
 

diff --git a/include/rnnoise.hpp b/include/rnnoise.hpp
@@ -19,6 +19,16 @@
 
 #pragma once
 
+#include <sigc++/signal.h>
+#include <sys/types.h>
+#include <algorithm>
+#include <climits>
+#include <cstddef>
+#include <memory>
+#include <span>
+#include <string>
+#include <vector>
+#include "pipe_manager.hpp"
 #ifdef ENABLE_RNNOISE
 #include <rnnoise.h>
 #endif