From bbf45bc8b7d101eae9edac57399043ae8f50bb7e Mon Sep 17 00:00:00 2001
From: wwmm <wellingtonwallace@gmail.com>
Date: Sat, 9 Mar 2024 22:41:22 -0300
Subject: [PATCH] clang-tidy: implementing some suggestions

---
 include/client_info_holder.hpp            | 2 --
 include/compressor.hpp                    | 1 -
 include/convolver_menu_combine.hpp        | 3 +--
 include/expander.hpp                      | 1 +
 include/gate.hpp                          | 2 +-
 include/limiter.hpp                       | 2 +-
 include/lv2_wrapper.hpp                   | 8 --------
 include/multiband_compressor_band_box.hpp | 1 -
 include/multiband_gate.hpp                | 2 +-
 include/multiband_gate_band_box.hpp       | 1 -
 include/pipe_manager.hpp                  | 7 -------
 include/plugin_base.hpp                   | 1 -
 include/presets_autoloading_holder.hpp    | 2 --
 include/presets_manager.hpp               | 2 --
 include/tags_plugin_name.hpp              | 1 -
 src/ui_helpers.cpp                        | 1 +
 16 files changed, 6 insertions(+), 31 deletions(-)

diff --git a/include/client_info_holder.hpp b/include/client_info_holder.hpp
index fe34dd39a..1b8d0e05e 100644
--- a/include/client_info_holder.hpp
+++ b/include/client_info_holder.hpp
@@ -21,8 +21,6 @@
 
 #include <glib-object.h>
 #include <glibconfig.h>
-#include <gobject/gobject.h>
-#include <gtk/gtk.h>
 #include <sigc++/signal.h>
 #include "pipe_objects.hpp"
 
diff --git a/include/compressor.hpp b/include/compressor.hpp
index 9834360c0..7589b10cb 100644
--- a/include/compressor.hpp
+++ b/include/compressor.hpp
@@ -19,7 +19,6 @@
 
 #pragma once
 
-#include <pipewire/context.h>
 #include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
diff --git a/include/convolver_menu_combine.hpp b/include/convolver_menu_combine.hpp
index f2756ea2e..271c58bb6 100644
--- a/include/convolver_menu_combine.hpp
+++ b/include/convolver_menu_combine.hpp
@@ -19,10 +19,9 @@
 
 #pragma once
 
-#include <adwaita.h>
 #include <glib-object.h>
 #include <glibconfig.h>
-#include <gtk/gtkpopover.h>
+#include <gtk/gtk.h>
 #include <string>
 
 namespace ui::convolver_menu_combine {
diff --git a/include/expander.hpp b/include/expander.hpp
index 3ca3b4e7b..d7ed79917 100644
--- a/include/expander.hpp
+++ b/include/expander.hpp
@@ -20,6 +20,7 @@
 #pragma once
 
 #include <pipewire/context.h>
+#include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
 #include <span>
diff --git a/include/gate.hpp b/include/gate.hpp
index 27e726107..dab71a9de 100644
--- a/include/gate.hpp
+++ b/include/gate.hpp
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <pipewire/context.h>
+#include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
 #include <span>
diff --git a/include/limiter.hpp b/include/limiter.hpp
index c91f5f916..7f1bc6fe7 100644
--- a/include/limiter.hpp
+++ b/include/limiter.hpp
@@ -19,7 +19,7 @@
 
 #pragma once
 
-#include <pipewire/context.h>
+#include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
 #include <span>
diff --git a/include/lv2_wrapper.hpp b/include/lv2_wrapper.hpp
index 64861e7fb..4d8e7fc12 100644
--- a/include/lv2_wrapper.hpp
+++ b/include/lv2_wrapper.hpp
@@ -19,20 +19,12 @@
 
 #pragma once
 
-#include <dlfcn.h>
 #include <gio/gio.h>
 #include <glib-object.h>
 #include <glib.h>
 #include <lilv/lilv.h>
-#include <lv2/atom/atom.h>
 #include <lv2/buf-size/buf-size.h>
 #include <lv2/core/lv2.h>
-#include <lv2/data-access/data-access.h>
-#include <lv2/instance-access/instance-access.h>
-#include <lv2/lv2plug.in/ns/ext/log/log.h>
-#include <lv2/lv2plug.in/ns/ext/urid/urid.h>
-#include <lv2/options/options.h>
-#include <lv2/parameters/parameters.h>
 #include <lv2/ui/ui.h>
 #include <lv2/urid/urid.h>
 #include <sys/types.h>
diff --git a/include/multiband_compressor_band_box.hpp b/include/multiband_compressor_band_box.hpp
index 0d5a96640..f5bec25b0 100644
--- a/include/multiband_compressor_band_box.hpp
+++ b/include/multiband_compressor_band_box.hpp
@@ -22,7 +22,6 @@
 #include <adwaita.h>
 #include <gio/gio.h>
 #include <glib-object.h>
-#include <glib/gi18n.h>
 #include <glibconfig.h>
 #include <gtk/gtkbox.h>
 
diff --git a/include/multiband_gate.hpp b/include/multiband_gate.hpp
index 5b33e88d6..8a1bf8c72 100644
--- a/include/multiband_gate.hpp
+++ b/include/multiband_gate.hpp
@@ -22,7 +22,7 @@
 #include <gio/gio.h>
 #include <glib-object.h>
 #include <glib.h>
-#include <pipewire/context.h>
+#include <pipewire/proxy.h>
 #include <sigc++/signal.h>
 #include <sys/types.h>
 #include <array>
diff --git a/include/multiband_gate_band_box.hpp b/include/multiband_gate_band_box.hpp
index 2b77f3d53..0c863f249 100644
--- a/include/multiband_gate_band_box.hpp
+++ b/include/multiband_gate_band_box.hpp
@@ -22,7 +22,6 @@
 #include <adwaita.h>
 #include <gio/gio.h>
 #include <glib-object.h>
-#include <glib/gi18n.h>
 #include <glibconfig.h>
 #include <gtk/gtkbox.h>
 
diff --git a/include/pipe_manager.hpp b/include/pipe_manager.hpp
index 9063b0976..9e12d835d 100644
--- a/include/pipe_manager.hpp
+++ b/include/pipe_manager.hpp
@@ -22,18 +22,11 @@
 #include <pipewire/context.h>
 #include <pipewire/core.h>
 #include <pipewire/extensions/metadata.h>
-#include <pipewire/pipewire.h>
 #include <pipewire/proxy.h>
 #include <pipewire/thread-loop.h>
-#include <sigc++/sigc++.h>
 #include <sigc++/signal.h>
-#include <spa/monitor/device.h>
-#include <spa/param/audio/format-utils.h>
-#include <spa/param/audio/type-info.h>
 #include <spa/utils/hook.h>
 #include <spa/utils/json.h>
-#include <spa/utils/keys.h>
-#include <spa/utils/result.h>
 #include <sys/types.h>
 #include <array>
 #include <cstddef>
diff --git a/include/plugin_base.hpp b/include/plugin_base.hpp
index c1918d75d..1d9481b67 100644
--- a/include/plugin_base.hpp
+++ b/include/plugin_base.hpp
@@ -23,7 +23,6 @@
 #include <glib.h>
 #include <pipewire/filter.h>
 #include <sigc++/signal.h>
-#include <spa/param/latency-utils.h>
 #include <spa/utils/hook.h>
 #include <sys/types.h>
 #include <chrono>
diff --git a/include/presets_autoloading_holder.hpp b/include/presets_autoloading_holder.hpp
index e9a61956d..aa722a09c 100644
--- a/include/presets_autoloading_holder.hpp
+++ b/include/presets_autoloading_holder.hpp
@@ -21,8 +21,6 @@
 
 #include <glib-object.h>
 #include <glibconfig.h>
-#include <gobject/gobject.h>
-#include <gtk/gtk.h>
 #include <string>
 
 namespace ui::holders {
diff --git a/include/presets_manager.hpp b/include/presets_manager.hpp
index d721f824b..aa9d82db3 100644
--- a/include/presets_manager.hpp
+++ b/include/presets_manager.hpp
@@ -20,11 +20,9 @@
 #pragma once
 
 #include <gio/gio.h>
-#include <sigc++/sigc++.h>
 #include <sigc++/signal.h>
 #include <filesystem>
 #include <memory>
-#include <nlohmann/json.hpp>
 #include <nlohmann/json_fwd.hpp>
 #include <optional>
 #include <string>
diff --git a/include/tags_plugin_name.hpp b/include/tags_plugin_name.hpp
index ca2e8809b..7d5c33767 100644
--- a/include/tags_plugin_name.hpp
+++ b/include/tags_plugin_name.hpp
@@ -19,7 +19,6 @@
 
 #pragma once
 
-#include <glib/gi18n.h>
 #include <sys/types.h>
 #include <array>
 #include <map>
diff --git a/src/ui_helpers.cpp b/src/ui_helpers.cpp
index 5a3098539..4590b3e3b 100644
--- a/src/ui_helpers.cpp
+++ b/src/ui_helpers.cpp
@@ -19,6 +19,7 @@
 
 #include "ui_helpers.hpp"
 #include <adwaita.h>
+#include <glib-object.h>
 #define FMT_HEADER_ONLY
 #include <fmt/core.h>
 #include <fmt/format.h>