Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various changes.
The most important is the one about
add_new_plugin_to_pipeline
function. Many releases ago we introduced the "limiter protection" system that places a new "non-limiter" plugin at the second to last position when the limiter (or the maximizer) is in the last position.Unfortunately this behavior broke when the level meter was introduced. The level meter does not change the signal, so we put it directly at the bottom of the pipeline (this is the position where the user wants the meter in most cases).
This causes any additional non-limiter plugin to be placed at the bottom, so after the limiter, which is not preferable. I noticed this behavior adding all the plugins at once. In the previous releases I had always a limiter/maximizer at the bottom. Now that the level meter can be added to the pipeline, I don't see the limiter at the bottom anymore (in better words, I see it at the last position until the level meter is added).
This is not the original intended behavior, so I changed the algorithm to check if the level meter in the last position is preceded by a limiter. TLDR: a new non-limiter plugin is added in the third to last position if the level meter at the bottom is preceded by a limiter: new-plugin -> limiter -> level meter. @wwmm please test this behavior.
Then there are some UI changes: