Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #2997

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Various fixes #2997

merged 7 commits into from
Mar 24, 2024

Conversation

Digitalone1
Copy link
Contributor

This PR contains various changes.

The most important is the one about add_new_plugin_to_pipeline function. Many releases ago we introduced the "limiter protection" system that places a new "non-limiter" plugin at the second to last position when the limiter (or the maximizer) is in the last position.

Unfortunately this behavior broke when the level meter was introduced. The level meter does not change the signal, so we put it directly at the bottom of the pipeline (this is the position where the user wants the meter in most cases).

This causes any additional non-limiter plugin to be placed at the bottom, so after the limiter, which is not preferable. I noticed this behavior adding all the plugins at once. In the previous releases I had always a limiter/maximizer at the bottom. Now that the level meter can be added to the pipeline, I don't see the limiter at the bottom anymore (in better words, I see it at the last position until the level meter is added).

This is not the original intended behavior, so I changed the algorithm to check if the level meter in the last position is preceded by a limiter. TLDR: a new non-limiter plugin is added in the third to last position if the level meter at the bottom is preceded by a limiter: new-plugin -> limiter -> level meter. @wwmm please test this behavior.

Then there are some UI changes:

  • some plugins had adwpreferences aligned (see Pitch) while others not; now all are aligned;
  • the reset history button in Autogain is now inside the Controls group (top space is not wasted);
  • the reset history button in Level Meter has been moved at the bottom taking the opportunity to fill the empty space left by the missing reset controls button;
  • the Filter had an adwpreferences too long; now it has been split in two groups like some of the other plugins (see Pitch);
  • the preset autoload page now has labels for device/preset dropdowns

Copy link

github-actions bot commented Mar 24, 2024

Workflow failed, but the following artifacts are still available for this pull request:

@wwmm wwmm merged commit 977c90a into wwmm:master Mar 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants